You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Pete Robbins (JIRA)" <tu...@ws.apache.org> on 2006/09/29 17:03:50 UTC

[jira] Created: (TUSCANY-764) Replace SDOString with std::string

Replace SDOString with std::string
----------------------------------

                 Key: TUSCANY-764
                 URL: http://issues.apache.org/jira/browse/TUSCANY-764
             Project: Tuscany
          Issue Type: Improvement
          Components: C++ SDO
    Affects Versions: Cpp-current
            Reporter: Pete Robbins
         Assigned To: Pete Robbins
             Fix For: Cpp-current
         Attachments: SDOString.patch

SDOString is unnecessary and adds no function over std::string

I'd like to propose we get rid of SDOString and just use std::string. SDOString inherits from std::string but does not add any additional function. The initial idea of having SDOString was to add an additional operator const char*() so that when we changed public API return values from const char* to SDOString a user would not have to ammend their code. However, this didn't quite work so I believe SDOString is redundant. 
 
I experimented by typedef'ing SDOString to std::string and it won't be too tricky to fix the few compile errors. I will hold off checking this in until we have consensus that it is the right thing to do.
 
Next, we have many duplicate methods that take parameters as string or char*. I would like to remove all the methods that take char* as const string& will work just as well without causing users problems. I realise that this is currently being discussed by the spec group and the current spec has the interfaces using char*, however for input paramters this proposal will still support the methods as if they were passing char* so I think we should go for it. I'm sure the spec group will get round to agreeing woth this ;-) 
 
Finally, and a bit later, we need to look at changing the public APIs that return char* to return std::string but this can wait for the spec group to decide if this is what they want. This will affect users as they will need to use .c_str() on their return values if they require th char* string. 
 
Cheers,

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Closed: (TUSCANY-764) Replace SDOString with std::string

Posted by "Pete Robbins (JIRA)" <tu...@ws.apache.org>.
     [ http://issues.apache.org/jira/browse/TUSCANY-764?page=all ]

Pete Robbins closed TUSCANY-764.
--------------------------------


> Replace SDOString with std::string
> ----------------------------------
>
>                 Key: TUSCANY-764
>                 URL: http://issues.apache.org/jira/browse/TUSCANY-764
>             Project: Tuscany
>          Issue Type: Improvement
>          Components: C++ SDO
>    Affects Versions: Cpp-current
>            Reporter: Pete Robbins
>         Assigned To: Pete Robbins
>             Fix For: Cpp-current
>
>         Attachments: SDOString.patch, TUSCANY-764.patch
>
>
> SDOString is unnecessary and adds no function over std::string
> I'd like to propose we get rid of SDOString and just use std::string. SDOString inherits from std::string but does not add any additional function. The initial idea of having SDOString was to add an additional operator const char*() so that when we changed public API return values from const char* to SDOString a user would not have to ammend their code. However, this didn't quite work so I believe SDOString is redundant. 
>  
> I experimented by typedef'ing SDOString to std::string and it won't be too tricky to fix the few compile errors. I will hold off checking this in until we have consensus that it is the right thing to do.
>  
> Next, we have many duplicate methods that take parameters as string or char*. I would like to remove all the methods that take char* as const string& will work just as well without causing users problems. I realise that this is currently being discussed by the spec group and the current spec has the interfaces using char*, however for input paramters this proposal will still support the methods as if they were passing char* so I think we should go for it. I'm sure the spec group will get round to agreeing woth this ;-) 
>  
> Finally, and a bit later, we need to look at changing the public APIs that return char* to return std::string but this can wait for the spec group to decide if this is what they want. This will affect users as they will need to use .c_str() on their return values if they require th char* string. 
>  
> Cheers,

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Commented: (TUSCANY-764) Replace SDOString with std::string

Posted by "Pete Robbins (JIRA)" <tu...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/TUSCANY-764?page=comments#action_12438734 ] 
            
Pete Robbins commented on TUSCANY-764:
--------------------------------------

In addition to the patch for Linux you need to delete the line
    SDOString.cpp \
from the cpp/sdo/runtime/core/src/commonj/sdo/Makefile.am

> Replace SDOString with std::string
> ----------------------------------
>
>                 Key: TUSCANY-764
>                 URL: http://issues.apache.org/jira/browse/TUSCANY-764
>             Project: Tuscany
>          Issue Type: Improvement
>          Components: C++ SDO
>    Affects Versions: Cpp-current
>            Reporter: Pete Robbins
>         Assigned To: Pete Robbins
>             Fix For: Cpp-current
>
>         Attachments: SDOString.patch, TUSCANY-764.patch
>
>
> SDOString is unnecessary and adds no function over std::string
> I'd like to propose we get rid of SDOString and just use std::string. SDOString inherits from std::string but does not add any additional function. The initial idea of having SDOString was to add an additional operator const char*() so that when we changed public API return values from const char* to SDOString a user would not have to ammend their code. However, this didn't quite work so I believe SDOString is redundant. 
>  
> I experimented by typedef'ing SDOString to std::string and it won't be too tricky to fix the few compile errors. I will hold off checking this in until we have consensus that it is the right thing to do.
>  
> Next, we have many duplicate methods that take parameters as string or char*. I would like to remove all the methods that take char* as const string& will work just as well without causing users problems. I realise that this is currently being discussed by the spec group and the current spec has the interfaces using char*, however for input paramters this proposal will still support the methods as if they were passing char* so I think we should go for it. I'm sure the spec group will get round to agreeing woth this ;-) 
>  
> Finally, and a bit later, we need to look at changing the public APIs that return char* to return std::string but this can wait for the spec group to decide if this is what they want. This will affect users as they will need to use .c_str() on their return values if they require th char* string. 
>  
> Cheers,

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Updated: (TUSCANY-764) Replace SDOString with std::string

Posted by "Pete Robbins (JIRA)" <tu...@ws.apache.org>.
     [ http://issues.apache.org/jira/browse/TUSCANY-764?page=all ]

Pete Robbins updated TUSCANY-764:
---------------------------------

    Attachment: SDOString.patch

This is a patch showing an initial step to typedef SDOString to std::string

I will apply this if we get consensus to do so

> Replace SDOString with std::string
> ----------------------------------
>
>                 Key: TUSCANY-764
>                 URL: http://issues.apache.org/jira/browse/TUSCANY-764
>             Project: Tuscany
>          Issue Type: Improvement
>          Components: C++ SDO
>    Affects Versions: Cpp-current
>            Reporter: Pete Robbins
>         Assigned To: Pete Robbins
>             Fix For: Cpp-current
>
>         Attachments: SDOString.patch
>
>
> SDOString is unnecessary and adds no function over std::string
> I'd like to propose we get rid of SDOString and just use std::string. SDOString inherits from std::string but does not add any additional function. The initial idea of having SDOString was to add an additional operator const char*() so that when we changed public API return values from const char* to SDOString a user would not have to ammend their code. However, this didn't quite work so I believe SDOString is redundant. 
>  
> I experimented by typedef'ing SDOString to std::string and it won't be too tricky to fix the few compile errors. I will hold off checking this in until we have consensus that it is the right thing to do.
>  
> Next, we have many duplicate methods that take parameters as string or char*. I would like to remove all the methods that take char* as const string& will work just as well without causing users problems. I realise that this is currently being discussed by the spec group and the current spec has the interfaces using char*, however for input paramters this proposal will still support the methods as if they were passing char* so I think we should go for it. I'm sure the spec group will get round to agreeing woth this ;-) 
>  
> Finally, and a bit later, we need to look at changing the public APIs that return char* to return std::string but this can wait for the spec group to decide if this is what they want. This will affect users as they will need to use .c_str() on their return values if they require th char* string. 
>  
> Cheers,

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Updated: (TUSCANY-764) Replace SDOString with std::string

Posted by "Pete Robbins (JIRA)" <tu...@ws.apache.org>.
     [ http://issues.apache.org/jira/browse/TUSCANY-764?page=all ]

Pete Robbins updated TUSCANY-764:
---------------------------------

    Attachment: TUSCANY-764.patch

ok... try the correct patch :-(

> Replace SDOString with std::string
> ----------------------------------
>
>                 Key: TUSCANY-764
>                 URL: http://issues.apache.org/jira/browse/TUSCANY-764
>             Project: Tuscany
>          Issue Type: Improvement
>          Components: C++ SDO
>    Affects Versions: Cpp-current
>            Reporter: Pete Robbins
>         Assigned To: Pete Robbins
>             Fix For: Cpp-current
>
>         Attachments: SDOString.patch, TUSCANY-764.patch
>
>
> SDOString is unnecessary and adds no function over std::string
> I'd like to propose we get rid of SDOString and just use std::string. SDOString inherits from std::string but does not add any additional function. The initial idea of having SDOString was to add an additional operator const char*() so that when we changed public API return values from const char* to SDOString a user would not have to ammend their code. However, this didn't quite work so I believe SDOString is redundant. 
>  
> I experimented by typedef'ing SDOString to std::string and it won't be too tricky to fix the few compile errors. I will hold off checking this in until we have consensus that it is the right thing to do.
>  
> Next, we have many duplicate methods that take parameters as string or char*. I would like to remove all the methods that take char* as const string& will work just as well without causing users problems. I realise that this is currently being discussed by the spec group and the current spec has the interfaces using char*, however for input paramters this proposal will still support the methods as if they were passing char* so I think we should go for it. I'm sure the spec group will get round to agreeing woth this ;-) 
>  
> Finally, and a bit later, we need to look at changing the public APIs that return char* to return std::string but this can wait for the spec group to decide if this is what they want. This will affect users as they will need to use .c_str() on their return values if they require th char* string. 
>  
> Cheers,

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Resolved: (TUSCANY-764) Replace SDOString with std::string

Posted by "Pete Robbins (JIRA)" <tu...@ws.apache.org>.
     [ http://issues.apache.org/jira/browse/TUSCANY-764?page=all ]

Pete Robbins resolved TUSCANY-764.
----------------------------------

    Resolution: Fixed

> Replace SDOString with std::string
> ----------------------------------
>
>                 Key: TUSCANY-764
>                 URL: http://issues.apache.org/jira/browse/TUSCANY-764
>             Project: Tuscany
>          Issue Type: Improvement
>          Components: C++ SDO
>    Affects Versions: Cpp-current
>            Reporter: Pete Robbins
>         Assigned To: Pete Robbins
>             Fix For: Cpp-current
>
>         Attachments: SDOString.patch, TUSCANY-764.patch
>
>
> SDOString is unnecessary and adds no function over std::string
> I'd like to propose we get rid of SDOString and just use std::string. SDOString inherits from std::string but does not add any additional function. The initial idea of having SDOString was to add an additional operator const char*() so that when we changed public API return values from const char* to SDOString a user would not have to ammend their code. However, this didn't quite work so I believe SDOString is redundant. 
>  
> I experimented by typedef'ing SDOString to std::string and it won't be too tricky to fix the few compile errors. I will hold off checking this in until we have consensus that it is the right thing to do.
>  
> Next, we have many duplicate methods that take parameters as string or char*. I would like to remove all the methods that take char* as const string& will work just as well without causing users problems. I realise that this is currently being discussed by the spec group and the current spec has the interfaces using char*, however for input paramters this proposal will still support the methods as if they were passing char* so I think we should go for it. I'm sure the spec group will get round to agreeing woth this ;-) 
>  
> Finally, and a bit later, we need to look at changing the public APIs that return char* to return std::string but this can wait for the spec group to decide if this is what they want. This will affect users as they will need to use .c_str() on their return values if they require th char* string. 
>  
> Cheers,

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org