You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "necouchman (via GitHub)" <gi...@apache.org> on 2023/08/29 21:21:00 UTC

[GitHub] [guacamole-client] necouchman opened a new pull request, #907: GUACAMOLE-1851: Add Inject notation to RequestValidationService constructor to fix Guice loading.

necouchman opened a new pull request, #907:
URL: https://github.com/apache/guacamole-client/pull/907

   Adds the `@Inject` notation to the constructor in `RequestValidationService` class so that it loads correctly with Guice, correcting an issue introduced by the addition of the parameterized construction from GUACAMOLE-1809.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [guacamole-client] mike-jumper merged pull request #907: GUACAMOLE-1851: Add Inject notation to RequestValidationService constructor to fix Guice loading.

Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper merged PR #907:
URL: https://github.com/apache/guacamole-client/pull/907


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [guacamole-client] necouchman commented on a diff in pull request #907: GUACAMOLE-1851: Add Inject notation to RequestValidationService constructor to fix Guice loading.

Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on code in PR #907:
URL: https://github.com/apache/guacamole-client/pull/907#discussion_r1309446686


##########
extensions/guacamole-auth-json/src/main/java/org/apache/guacamole/auth/json/RequestValidationService.java:
##########
@@ -52,6 +52,7 @@ public class RequestValidationService {
      * @param confService
      *     The (mock) instance of ConfigurationService
      */
+    @Inject

Review Comment:
   Good point - I'll take a look at both those items and refactor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [guacamole-client] mike-jumper commented on a diff in pull request #907: GUACAMOLE-1851: Add Inject notation to RequestValidationService constructor to fix Guice loading.

Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper commented on code in PR #907:
URL: https://github.com/apache/guacamole-client/pull/907#discussion_r1309385262


##########
extensions/guacamole-auth-json/src/main/java/org/apache/guacamole/auth/json/RequestValidationService.java:
##########
@@ -52,6 +52,7 @@ public class RequestValidationService {
      * @param confService
      *     The (mock) instance of ConfigurationService
      */
+    @Inject

Review Comment:
   With this annotation present, does the `@Inject` on the `confService` member variable have any effect? Or are things now injected purely through invoking this constructor?
   
   If only the constructor is used, then the docs for the constructor should probably be updated to capture its true usage, which is no longer specific to unit testing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org