You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ambari.apache.org by "sandeep318kumar (via GitHub)" <gi...@apache.org> on 2024/09/25 05:10:17 UTC
[PR] [AMBARI-26142] JDK17 support for Ambari-metrics [ambari-metrics]
sandeep318kumar opened a new pull request, #134:
URL: https://github.com/apache/ambari-metrics/pull/134
[AMBARI-26142] JDK17 support for Ambari-metrics
<!---
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
--->
## What changes were proposed in this pull request?
upgrade maven-compiler-plugin to 3.5
maven-shade-plugin to 3.5.1
guava to 32.1.3-jre
maven-surefire-plugin to 3.2.5
JDK to 17
API changes
tests cases modified
(Please fill in changes proposed in this fix)
## How was this patch tested?
TESTING is pending.
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org
Re: [PR] AMBARI-26142: JDK17 support for Ambari-metrics [ambari-metrics]
Posted by "vishalsuvagia (via GitHub)" <gi...@apache.org>.
vishalsuvagia commented on PR #134:
URL: https://github.com/apache/ambari-metrics/pull/134#issuecomment-3520366928
Hi @JiaLiangC we would need the JDK-17 support in Ambari metrics to enable helix-core fix https://github.com/apache/ambari-metrics/pull/173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org
Re: [PR] AMBARI-26142: JDK17 support for Ambari-metrics [ambari-metrics]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #134:
URL: https://github.com/apache/ambari-metrics/pull/134#issuecomment-2522453531
> @JiaLiangC Can I work on these test cases?
@sandeep318kumar sorry for later reply, of course you can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org
Re: [PR] [AMBARI-26142] JDK17 support for Ambari-metrics [ambari-metrics]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #134:
URL: https://github.com/apache/ambari-metrics/pull/134#issuecomment-2507140249
@sandeep318kumar It will be merged first, and the failed unit tests will be submitted in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org
Re: [PR] [AMBARI-26142] JDK17 support for Ambari-metrics [ambari-metrics]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #134:
URL: https://github.com/apache/ambari-metrics/pull/134#issuecomment-2463692356
@sandeep318kumar
Due to being quite busy, we will handle the Ambari metrics-related PRs after completing the JDK, Spring, and other dependency upgrades on the Ambari side. Thank you for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org
Re: [PR] [AMBARI-26142] JDK17 support for Ambari-metrics [ambari-metrics]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC merged PR #134:
URL: https://github.com/apache/ambari-metrics/pull/134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org
Re: [PR] AMBARI-26142: JDK17 support for Ambari-metrics [ambari-metrics]
Posted by "sandeep318kumar (via GitHub)" <gi...@apache.org>.
sandeep318kumar commented on PR #134:
URL: https://github.com/apache/ambari-metrics/pull/134#issuecomment-2507201910
@JiaLiangC Can I work on these test cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org
Re: [PR] [AMBARI-26142] JDK17 support for Ambari-metrics [ambari-metrics]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #134:
URL: https://github.com/apache/ambari-metrics/pull/134#issuecomment-2463699376
@sandeep318kumar It looks like three tests have failed. Could you please fix them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org