[GitHub] [zookeeper] symat commented on a change in pull request #1363: Add log for UnimplementedException on reconfig.

[GitBox <gi...@apache.org>]

symat commented on a change in pull request #1363:
URL: https://github.com/apache/zookeeper/pull/1363#discussion_r436699344



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java
##########
@@ -419,7 +419,7 @@ protected void pRequest2Txn(int type, long zxid, Request request, Record record,
             try {
                 lzks = (LeaderZooKeeperServer) zks;
             } catch (ClassCastException e) {
-                // standalone mode - reconfiguration currently not supported
+                LOG.error("Reconfig operation requested but this feature is currently not supported on standalone mode.”);
                 throw new KeeperException.UnimplementedException();
             }

Review comment:
       I agree with @maoling, I also feel that a WARN would be more appropriate here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org