[jira] Commented: (PIVOT-447) TextInput Component's selection methods throw NPE when textNode property is null

["Thomas Guretzki (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIVOT-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850945#action_12850945 ] 

Thomas Guretzki commented on PIVOT-447:
---------------------------------------

TextInput's setText method is
"public void setText(String text) {
        setTextNode((text == null) ? null : new TextNode(text));
    }", 
so an empty Text produces a null TextNode.
Is that really an illegal state? 
The problem came up for me when I tried to edit in a TableView where one column was bound to a null value.
I think that should be possible, don't you?

> TextInput Component's selection methods throw NPE when textNode property is null
> --------------------------------------------------------------------------------
>
>                 Key: PIVOT-447
>                 URL: https://issues.apache.org/jira/browse/PIVOT-447
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>    Affects Versions: 1.4
>         Environment: Windows XP, Java 1.6.0_17
>            Reporter: Thomas Guretzki
>             Fix For: 1.5
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> TextInput Component: setSelection(int selectionStart, int selectionLength): 
> third <if> should be:
> "if (selectionStart < 0
>             || selectionStart + selectionLength > (textNode == null ? 0 : textNode.getCharacterCount())) "
> or something similar

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.