[GitHub] [incubator-superset] robdiciuccio commented on a change in pull request #8941: [dashboards] New, export api

[GitBox <gi...@apache.org>]

robdiciuccio commented on a change in pull request #8941: [dashboards] New, export api
URL: https://github.com/apache/incubator-superset/pull/8941#discussion_r366115353
 
 

 ##########
 File path: superset/views/dashboard/api.py
 ##########
 @@ -169,6 +173,7 @@ class DashboardRestApi(DashboardMixin, BaseSupersetModelRestApi):
     method_permission_name = {
         "get_list": "list",
         "get": "show",
+        "export": "list",
 
 Review comment:
   Seems like a different level of permission if the export also contains all of the chart and data source info. Was this the `can_download_dashboards` permission? Can we use the same?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org