You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by jpeach <gi...@git.apache.org> on 2016/05/14 04:08:21 UTC
[GitHub] trafficserver pull request: TS-4441: Stop dumping core on fatal er...
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/641
TS-4441: Stop dumping core on fatal errors.
On a fatal error, the core file is rarely useful, and there is a
real risk of filling up a disk with cores when we get a bad
configuration. Rather than dumping core when logging a fatal error,
just exit.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver fix/TS-4441
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/641.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #641
----
commit b62299373dca7d93462d2f35c93fe44d693c1e96
Author: James Peach <jp...@apache.org>
Date: 2016-05-14T04:04:59Z
TS-4441: Stop dumpoing core on fatal errors.
On a fatal error, the core file is rarely useful, and there is a
real risk of filling up a disk with cores when we get a bad
configuration. Rather than dumping core when logging a fatal error,
just exit.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4441: Stop dumping core on fatal er...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/641#issuecomment-219237509
This didn't pass clang-format test either.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4441: Stop dumping core on fatal er...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/641
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4441: Stop dumping core on fatal er...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/641#issuecomment-219199860
Hmmm, I have debugged many useful cores when the die_die_die call was made. I can see this fix being a good idea during config load, but wouldn't this fail to generate core files which we really want?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4441: Stop dumping core on fatal er...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/641#issuecomment-219253268
I replaced instances of ``ink_fatal`` that should dump core with ``ink_abort``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---