You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "iamhucong (via GitHub)" <gi...@apache.org> on 2026/08/12 05:55:05 UTC
[PR] Add PostgreSQL column nullability release note [shardingsphere]
iamhucong opened a new pull request, #39420:
URL: https://github.com/apache/shardingsphere/pull/39420
Add the missing ShardingSphere 5.5.4 bug-fix release note for #39412.
The entry records that the PostgreSQL SQL parser now preserves `CREATE TABLE` column nullability metadata.
### Verification
- Spotless passed.
- Checkstyle reported 0 violations.
- `git diff --check` passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add PostgreSQL column nullability release note [shardingsphere]
Posted by "FlyingZC (via GitHub)" <gi...@apache.org>.
FlyingZC merged PR #39420:
URL: https://github.com/apache/shardingsphere/pull/39420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add PostgreSQL column nullability release note [shardingsphere]
Posted by "iamhucong (via GitHub)" <gi...@apache.org>.
iamhucong commented on PR #39420:
URL: https://github.com/apache/shardingsphere/pull/39420#issuecomment-5263004015
### Result
**Review Result: Mergeable**
The release-note entry accurately describes merged PR #39412 and is correctly placed under the ShardingSphere 5.5.4 bug fixes.
### Evidence
- Reviewed public head: `9e9b1112c77f75304310266ad92afaf4aeb49008`.
- PR #39412 is merged as `Parse PostgreSQL column NOT NULL constraints`.
- Its production change preserves PostgreSQL `CREATE TABLE` column nullability in `ColumnDefinitionSegment`.
- Its parser baseline verifies:
- `INT NOT NULL` → `not-null="true"`
- `INT NULL` → `not-null="false"`
- `RELEASE-NOTES.md:21` accurately summarizes this behavior and links to https://github.com/apache/shardingsphere/pull/39412.
- The link resolves successfully, and #39412 appears exactly once in the 5.5.4 section.
- Sanitized verification:
- Spotless passed.
- Checkstyle reported 0 violations.
- Triple-dot `git diff --check` passed.
### Coverage
- The authoritative GitHub scope contains one file, fully reviewed:
- `RELEASE-NOTES.md`
- The local triple-dot file list matches GitHub at merge base `a545666bc8c975f6746a566dd95a17744ba0995b`.
- Reviewed behavior cluster: documentation of the merged PostgreSQL column-nullability parser fix.
- The review checked source-PR status, implementation behavior, test baseline, release version, section classification, wording, link target, uniqueness, and adjacent release-note convention.
- No production code, tests, API, SPI, configuration, dependency, packaging, or generated artifacts are changed.
- Root-cause, blast-radius, tests/runtime/operations, and final full-scope convergence passes found no unresolved evidence gaps.
- This result is code-scope only; CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org