You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/12/21 06:15:02 UTC
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2856:
[GOBBLIN-1011] adjust compaction flow to work with virtual partition
codecov-io edited a comment on issue #2856: [GOBBLIN-1011] adjust compaction flow to work with virtual partition
URL: https://github.com/apache/incubator-gobblin/pull/2856#issuecomment-568155535
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2856?src=pr&el=h1) Report
> Merging [#2856](https://codecov.io/gh/apache/incubator-gobblin/pull/2856?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/070009231770e04aeb9a74a9d03865cb74cf4094?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `63.01%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2856?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2856 +/- ##
============================================
+ Coverage 45.57% 45.63% +0.05%
- Complexity 9032 9053 +21
============================================
Files 1908 1908
Lines 71729 71776 +47
Branches 7912 7921 +9
============================================
+ Hits 32693 32757 +64
+ Misses 36031 36007 -24
- Partials 3005 3012 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2856?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/compaction/suite/CompactionSuiteBaseFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2856/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvblN1aXRlQmFzZUZhY3RvcnkuamF2YQ==) | `100% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: |
| [...lin/hive/metastore/HiveMetaStoreBasedRegister.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2856/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlQmFzZWRSZWdpc3Rlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../gobblin/compaction/suite/CompactionSuiteBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2856/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvblN1aXRlQmFzZS5qYXZh) | `100% <100%> (ø)` | `8 <2> (ø)` | :arrow_down: |
| [.../apache/gobblin/runtime/task/TaskIFaceWrapper.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2856/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdGFzay9UYXNrSUZhY2VXcmFwcGVyLmphdmE=) | `68.62% <100%> (+1.96%)` | `14 <1> (+1)` | :arrow_up: |
| [...ain/java/org/apache/gobblin/time/TimeIterator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2856/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGltZS9UaW1lSXRlcmF0b3IuamF2YQ==) | `73.07% <62.5%> (+9.91%)` | `12 <5> (+8)` | :arrow_up: |
| [...che/gobblin/hive/metastore/HiveMetaStoreUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2856/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlVXRpbHMuamF2YQ==) | `35.58% <66.66%> (+3.88%)` | `15 <0> (+3)` | :arrow_up: |
| [.../action/CompactionCompleteFileOperationAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2856/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25Db21wbGV0ZUZpbGVPcGVyYXRpb25BY3Rpb24uamF2YQ==) | `62.5% <66.66%> (+0.2%)` | `5 <2> (+1)` | :arrow_up: |
| [...mpaction/action/CompactionMarkDirectoryAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2856/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25NYXJrRGlyZWN0b3J5QWN0aW9uLmphdmE=) | `44.44% <66.66%> (+2.77%)` | `5 <2> (+1)` | :arrow_up: |
| [...ction/action/CompactionHiveRegistrationAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2856/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25IaXZlUmVnaXN0cmF0aW9uQWN0aW9uLmphdmE=) | `34.61% <66.66%> (+4.18%)` | `5 <2> (+1)` | :arrow_up: |
| [...c/main/java/org/apache/gobblin/hive/HiveTable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2856/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL0hpdmVUYWJsZS5qYXZh) | `48.88% <71.42%> (+4.15%)` | `8 <1> (+1)` | :arrow_up: |
| ... and [15 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2856/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2856?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2856?src=pr&el=footer). Last update [0700092...a258710](https://codecov.io/gh/apache/incubator-gobblin/pull/2856?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services