You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/12/03 09:52:46 UTC
[GitHub] [maven] gnodet opened a new pull request #629: [MNG-7350] Introduce a factory for ModelCache
gnodet opened a new pull request #629:
URL: https://github.com/apache/maven/pull/629
`mvnd` does redefine a few maven classes in order to plugin its caching layer or change some behaviours, but this is sometime very difficult without copying some core class entirely.
One of those class is the `ProjectBuilder` and it's being reimplemented in `mvnd` only because the `ModelCache` is created using a direct call on the implementation.
This ticket aims to introduce a `ModelCacheFactory` so that `mvnd` can simply define a custom factory instead of redefining the full `ProjectBuilder`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet merged pull request #629: [master][MNG-7350] Introduce a factory for ModelCache
Posted by GitBox <gi...@apache.org>.
gnodet merged pull request #629:
URL: https://github.com/apache/maven/pull/629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #629: [master][MNG-7350] Introduce a factory for ModelCache
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #629:
URL: https://github.com/apache/maven/pull/629#issuecomment-985688442
Is https://github.com/apache/maven/pull/630/files#diff-50ddbca622e461d2056985a5c792fc4652574831f3a8b69da9be3a2f5af9e552R65 missing from here or I missed it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #629: [master][MNG-7350] Introduce a factory for ModelCache
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #629:
URL: https://github.com/apache/maven/pull/629#issuecomment-985686940
> This truly makes sense.
Actually all these "extension points" should be componentized (if not already), for easier extension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #629: [master][MNG-7350] Introduce a factory for ModelCache
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #629:
URL: https://github.com/apache/maven/pull/629#issuecomment-986523448
> Is https://github.com/apache/maven/pull/630/files#diff-50ddbca622e461d2056985a5c792fc4652574831f3a8b69da9be3a2f5af9e552R65 missing from here or I missed it?
Nice catch, I missed it because the module was renamed. I've also added a short javadoc on the two new classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas edited a comment on pull request #629: [master][MNG-7350] Introduce a factory for ModelCache
Posted by GitBox <gi...@apache.org>.
cstamas edited a comment on pull request #629:
URL: https://github.com/apache/maven/pull/629#issuecomment-985686940
> This truly makes sense.
Actually all these "extension points" should be componentized (if not already), for easier extension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org