[jira] [Commented] (ROCKETMQ-331) Make DLQ queue nums configurable

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16290393#comment-16290393 ] 

ASF GitHub Bot commented on ROCKETMQ-331:
-----------------------------------------

lindzh opened a new pull request #203: [ROCKETMQ-331] Make DLQ queue nums configurable
URL: https://github.com/apache/rocketmq/pull/203
 
 
   ## What is the purpose of the change
   
   As DLQ queue nums is configured to static as
   
   ```
   protected final static int DLQ_NUMS_PER_GROUP = 1;
   ```
   
   in some cases, we need to get messages from DLQ to recover,but queue nums of DLQ is limited and can't expand load.So I want to change the default DLQ queue nums default value.
   
   ## Brief changelog
   
   add dlqNumsPerGroup to BrokerConfig
   
   ## Verifying this change
   
   This is a trivial change.
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
   - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/ROCKETMQ/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ROCKETMQ-XXX] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [x] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make DLQ queue nums configurable
> --------------------------------
>
>                 Key: ROCKETMQ-331
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-331
>             Project: Apache RocketMQ
>          Issue Type: New Feature
>          Components: rocketmq-broker
>    Affects Versions: 4.1.0-incubating
>            Reporter: lindzh
>            Assignee: yukon
>             Fix For: 4.3.0
>
>
> As DLQ queue nums is configured to static as 
> {code:java}
> protected final static int DLQ_NUMS_PER_GROUP = 1;
> {code}
> in some cases, we need to get messages from DLQ to recover,but queue nums of DLQ is limited and can't expand load.So I want to change the default DLQ queue nums default value.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)