Re: svn commit: r730922 - in /maven/plugins/trunk/maven-ear-plugin: ./ src/main/java/org/apache/maven/plugin/ear/ src/site/apt/ src/test/java/org/apache/maven/plugin/ear/it/ src/test/resources/ src/test/resources/projects/project-042/expected-META-INF/ src...

[Benjamin Bentmann <be...@udo.edu>]

Hi Stéphane,

> Author: snicoll
> Date: Fri Jan  2 22:30:22 2009
> New Revision: 730922
> 
> URL: http://svn.apache.org/viewvc?rev=730922&view=rev
> Log:
> MEAR-78: when specified, the library configuration is now written properly in a JavaEE5 application.xml. Thanks to Markus Knittig.
> 
> Updated to XmlUnit 1.2 to allow to diff an xml properly even if the order of the elements are not the same. Please note that due to a bug in 2.0.9, the ITs won't pass. 2.0.8 must be used (see http://tinyurl.com/7au53p)
> 
> Added:
>     maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/ApplicationXmlWriterContext.java
> [...]
> 
> Added: maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/ApplicationXmlWriterContext.java
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/ApplicationXmlWriterContext.java?rev=730922&view=auto
> ==============================================================================
> --- maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/ApplicationXmlWriterContext.java (added)
> +++ maven/plugins/trunk/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/ApplicationXmlWriterContext.java Fri Jan  2 22:30:22 2009
> @@ -0,0 +1,103 @@
> +package org.apache.maven.plugin.ear;
> +
> +import java.io.File;
> +import java.util.List;
> +
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one
> + * or more contributor license agreements.  See the NOTICE file
> + * distributed with this work for additional information
> + * regarding copyright ownership.  The ASF licenses this file
> + * to you under the Apache License, Version 2.0 (the
> + * "License"); you may not use this file except in compliance
> + * with the License.  You may obtain a copy of the License at
> + *
> + *  http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing,
> + * software distributed under the License is distributed on an
> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> + * KIND, either express or implied.  See the License for the
> + * specific language governing permissions and limitations
> + * under the License.
> + */
> +
> +/**
> + * A context for the {@link ApplicationXmlWriter}.
> + *
> + * @author <a href="snicoll@apache.org">Stephane Nicoll</a>
> + * @version $Id: ApplicationXmlWriter.java 728546 2008-12-21 22:56:51Z bentmann $
> + */
> +class ApplicationXmlWriterContext {
> +
> +    private final File destinationFile;
> +    private final List earModules;
> +    private final List securityRoles;
> +    private final String displayName;
> +    private final String description;
> +    private final String libraryDirectory;
> +
> +    public ApplicationXmlWriterContext(File destinationFile, List earModules, List securityRoles,
> +                                       String displayName, String description, String libraryDirectory) {
> +        this.destinationFile = destinationFile;
> +        this.earModules = earModules;
> +        this.securityRoles = securityRoles;
> +        this.displayName = displayName;
> +        this.description = description;
> +        this.libraryDirectory = libraryDirectory;
> +    }
> +
> +    /**
> +     * Returns the name of the file to use to write application.xml to.
> +     *
> +     * @return the output file
> +     */
> +    public File getDestinationFile() {
> +        return destinationFile;
> +    }
> +
> +    /**
> +     * Returns the  list of {@link EarModule} instances.
> +     *
> +     * @return the ear modules
> +     */
> +    public List getEarModules() {
> +        return earModules;
> +    }
> +
> +    /**
> +     * Returns the list of {Žlink SecurityRole} instances.
> +     *
> +     * @return the security roles
> +     */
> +    public List getSecurityRoles() {
> +        return securityRoles;
> +    }
> +
> +    /**
> +     * Returns the display name.
> +     *
> +     * @return the display name
> +     */
> +    public String getDisplayName() {
> +        return displayName;
> +    }
> +
> +    /**
> +     * Returns the description.
> +     *
> +     * @return the description
> +     */
> +    public String getDescription() {
> +        return description;
> +    }
> +
> +    /**
> +     * Returns the library directory (as per JavaEE 5).
> +     *
> +     * @return the library directory
> +     */
> +    public String getLibraryDirectory() {
> +        return libraryDirectory;
> +    }
> +}
> 

When you're done with your ongoing work, please have your IDE update the 
code format.

Besides, this file and some others you added are lacking the svn props 
as outlined in [0].

Thanks,


Benjamin


[0] http://maven.apache.org/developers/committer-environment.html

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org