You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "msgui (via GitHub)" <gi...@apache.org> on 2024/03/04 11:02:06 UTC
[PR] fix: base-ref/head-ref missed in dependency-check-ci on schedule push [incubator-hugegraph-computer]
msgui opened a new pull request, #304:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/304
<!--
Thank you very much for contributing to Apache HugeGraph, we are happy that you want to help us improve it!
Here are some tips for you:
1. If this is your first time, please read the [contributing guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
2. If a PR will fix/close a issue, type the message "close xxx" (xxx is the link of related issue) in the content, github will auto link it (Required)
3. Name the PR title in "Google Commit Format", start with "feat | fix | perf | refactor | doc | chore",
such like: "feat(core): support the PageRank algorithm" or "fix: wrong break in the compute loop" (module is optional)
skip it if you are unsure about which is the best component.
4. One PR address one issue, better not to mix up multiple issues.
5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click it directly after published)
-->
## Purpose of the PR
Because scheduled tasks default to running on the master branch, the related parameters (`base_ref`/`head_ref`) were missing
ref:
1. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule
2. [#516](https://github.com/apache/incubator-hugegraph-toolchain/pull/516)
<!--
Please explain more context in this section, clarify why the changes are needed.
For example:
- If you propose a new API, clarify the use case for a new API.
- If you fix a bug, you can clarify why it is a bug, and should associated with an issue.
-->
## Main Changes
<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.)
For example:
- If you introduce a new feature, please show detailed design here or add the link of design documentation.
- If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
- If there is a discussion in the mailing list, please add the link. -->
## Verifying these changes
<!-- Please pick the proper options below -->
- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
- [ ] Already covered by existing tests, such as *(please modify tests here)*.
- [ ] Need tests and can be verified as follows.
<!-- Please provide more details about verification
For example:
- If you test manually, please provide related screenshot.
-->
## Does this PR potentially affect the following parts?
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] Nope
- [ ] Dependencies (add/update license info) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) -->
- [ ] Modify configurations
- [ ] The public API
- [ ] Other affects (typed here)
## Documentation Status
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `Doc - TODO` <!-- Your PR changes impact docs and you will update later -->
- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
- [ ] `Doc - No Need` <!-- Your PR changes don't impact/need docs -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix: base-ref/head-ref missed in dependency-review on schedule push [incubator-hugegraph-computer]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #304:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/304#issuecomment-1976353435
## [Codecov](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/304?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 85.17%. Comparing base [(`e0b484a`)](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/commit/e0b484a65e2244ec49ef8bbc14185acd99dbc436?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6c18e4f`)](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/304?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 7 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #304 +/- ##
============================================
+ Coverage 85.03% 85.17% +0.14%
- Complexity 3296 3299 +3
============================================
Files 349 349
Lines 12485 12461 -24
Branches 1130 1123 -7
============================================
- Hits 10616 10614 -2
+ Misses 1329 1306 -23
- Partials 540 541 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/304?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix: base-ref/head-ref missed in dependency-review on schedule push [incubator-hugegraph-computer]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #304:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/304#discussion_r1518801749
##########
.github/workflows/codeql-analysis.yml:
##########
@@ -6,8 +6,9 @@ on:
pull_request:
# The branches below must be a subset of the branches above, now enable it in all PR
# branches: [ master ]
- schedule:
- - cron: '45 7 * * 1'
+# The reason for deleting the scheduled task can be found in PR #304
Review Comment:
> can we move dependency-review out of this file instead? we may move dependency-review to ci.yaml or license-checker.yml?
`license-checker` also have some conflicts with the **exec param**, same as the `ci.yaml`
if we do need **schedule** for the codeql, we need add **a new file** for the `dependency-review` & seems it's not necessary and has no practical significance (Currently, the PR runs CodeQL directly which is enough for the check, maybe we could keep it simple & separate if we really need it)
##########
.github/workflows/codeql-analysis.yml:
##########
@@ -6,8 +6,9 @@ on:
pull_request:
# The branches below must be a subset of the branches above, now enable it in all PR
# branches: [ master ]
- schedule:
- - cron: '45 7 * * 1'
+# The reason for deleting the scheduled task can be found in PR #304
Review Comment:
> can we move dependency-review out of this file instead? we may move dependency-review to ci.yaml or license-checker.yml?
`license-checker` also have some conflicts with the **exec param**, same as the `ci.yaml`
if we do need **scheduler** for the codeql, we need add **a new file** for the `dependency-review` & seems it's not necessary and has no practical significance (Currently, the PR runs CodeQL directly which is enough for the check, maybe we could keep it simple & separate if we really need it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix: base-ref/head-ref missed in dependency-review on schedule push [incubator-hugegraph-computer]
Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme commented on code in PR #304:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/304#discussion_r1518720371
##########
.github/workflows/codeql-analysis.yml:
##########
@@ -6,8 +6,9 @@ on:
pull_request:
# The branches below must be a subset of the branches above, now enable it in all PR
# branches: [ master ]
- schedule:
- - cron: '45 7 * * 1'
+# The reason for deleting the scheduled task can be found in PR #304
Review Comment:
can we move dependency-review out of this file instead? we may move dependency-review to ci.yaml or license-checker.yml?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix: base-ref/head-ref missed in dependency-review on schedule push [incubator-hugegraph-computer]
Posted by "coderzc (via GitHub)" <gi...@apache.org>.
coderzc merged PR #304:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org