You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by nabarunnag <gi...@git.apache.org> on 2017/05/22 21:54:53 UTC
[GitHub] geode pull request #523: GEODE-2967: ResultCollection instead of StructColle...
GitHub user nabarunnag opened a pull request:
https://github.com/apache/geode/pull/523
GEODE-2967: ResultCollection instead of StructCollection
* If we have one runtime iterator which is in case of self joins, ResultSet or ResultBags are created
* Otherwise StructBag or StructSets are used
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2967
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/523.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #523
----
commit dfa777eff383119d99fe51d2ec6bfb7c099ca643
Author: nabarun <nn...@pivotal.io>
Date: 2017-05-22T18:34:52Z
GEODE-2967: ResultCollection instead of StructCollection
* If we have one runtime iterator which is in case of self joins, ResultSet or ResultBags are created
* Otherwise StructBag or StructSets are used
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #523: GEODE-2967: ResultCollection instead of StructColle...
Posted by nabarunnag <gi...@git.apache.org>.
Github user nabarunnag closed the pull request at:
https://github.com/apache/geode/pull/523
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #523: GEODE-2967: ResultCollection instead of StructCollection
Posted by nabarunnag <gi...@git.apache.org>.
Github user nabarunnag commented on the issue:
https://github.com/apache/geode/pull/523
Potential reviewers
@jhuynh1 @ladyVader @boglesby @gesterzhou @upthewaterspout
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #523: GEODE-2967: ResultCollection instead of StructCollection
Posted by nabarunnag <gi...@git.apache.org>.
Github user nabarunnag commented on the issue:
https://github.com/apache/geode/pull/523
@DivineEnder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---