You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/23 07:32:49 UTC
[GitHub] [flink] JingsongLi opened a new pull request #10660:
[FLINK-15361][parquet] ParquetTableSource should pass predicate in
projectFields
JingsongLi opened a new pull request #10660: [FLINK-15361][parquet] ParquetTableSource should pass predicate in projectFields
URL: https://github.com/apache/flink/pull/10660
## What is the purpose of the change
After projectFields, ParquetTableSource will loose predicates.
Since this is only performance related, the test did not fail.
## Brief change log
pass predicate in `ParquetTableSource.projectFields`.
## Verifying this change
Since volcano, it is hard to verify it.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 closed pull request #10660:
[FLINK-15361][parquet] ParquetTableSource should pass predicate in
projectFields
Posted by GitBox <gi...@apache.org>.
bowenli86 closed pull request #10660: [FLINK-15361][parquet] ParquetTableSource should pass predicate in projectFields
URL: https://github.com/apache/flink/pull/10660
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10660:
[FLINK-15361][parquet] ParquetTableSource should pass predicate in
projectFields
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10660: [FLINK-15361][parquet] ParquetTableSource should pass predicate in projectFields
URL: https://github.com/apache/flink/pull/10660#issuecomment-568398076
<!--
Meta data
Hash:d528727f623f42fc57ab1559d5c25c62dc503b89 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3853 TriggerType:PUSH TriggerID:d528727f623f42fc57ab1559d5c25c62dc503b89
Hash:d528727f623f42fc57ab1559d5c25c62dc503b89 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142086729 TriggerType:PUSH TriggerID:d528727f623f42fc57ab1559d5c25c62dc503b89
-->
## CI report:
* d528727f623f42fc57ab1559d5c25c62dc503b89 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142086729) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3853)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10660: [FLINK-15361][parquet]
ParquetTableSource should pass predicate in projectFields
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10660: [FLINK-15361][parquet] ParquetTableSource should pass predicate in projectFields
URL: https://github.com/apache/flink/pull/10660#issuecomment-568387389
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d528727f623f42fc57ab1559d5c25c62dc503b89 (Mon Dec 23 07:36:27 UTC 2019)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15361).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10660:
[FLINK-15361][parquet] ParquetTableSource should pass predicate in
projectFields
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10660: [FLINK-15361][parquet] ParquetTableSource should pass predicate in projectFields
URL: https://github.com/apache/flink/pull/10660#issuecomment-568398076
<!--
Meta data
Hash:d528727f623f42fc57ab1559d5c25c62dc503b89 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3853 TriggerType:PUSH TriggerID:d528727f623f42fc57ab1559d5c25c62dc503b89
Hash:d528727f623f42fc57ab1559d5c25c62dc503b89 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142086729 TriggerType:PUSH TriggerID:d528727f623f42fc57ab1559d5c25c62dc503b89
-->
## CI report:
* d528727f623f42fc57ab1559d5c25c62dc503b89 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142086729) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3853)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10660: [FLINK-15361][parquet]
ParquetTableSource should pass predicate in projectFields
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10660: [FLINK-15361][parquet] ParquetTableSource should pass predicate in projectFields
URL: https://github.com/apache/flink/pull/10660#issuecomment-568398076
<!--
Meta data
Hash:d528727f623f42fc57ab1559d5c25c62dc503b89 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d528727f623f42fc57ab1559d5c25c62dc503b89
-->
## CI report:
* d528727f623f42fc57ab1559d5c25c62dc503b89 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services