You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/10/19 17:56:43 UTC
[GitHub] [cordova-android] raphinesse opened a new pull request #1100: refactor!: remove platform binaries
raphinesse opened a new pull request #1100:
URL: https://github.com/apache/cordova-android/pull/1100
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
As discussed lately this removes all non-essential platform binaries.
My work to stop copying `cordova/lib` to the platform folder is based on this PR among others.
### TODO
- There are still places where `nopt` is used to parse arguments passed through from CLI. So we probably cannot remove it. Investigate.
- Some of the deleted binaries are actually [called from lib](https://github.com/apache/cordova-lib/blob/master/src/cordova/targets.js). That function is called when running `cordova run --list`. We should introduce a new Platform API function for getting that information. Until then we have to keep the `list-devices` and `list-emulator-images` binaries (including their `.bat` counterparts AFAICT from how lib calls them :unamused: )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] raphinesse merged pull request #1100: refactor!: remove most platform binaries
Posted by GitBox <gi...@apache.org>.
raphinesse merged pull request #1100:
URL: https://github.com/apache/cordova-android/pull/1100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1100: refactor!: remove most platform binaries
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1100:
URL: https://github.com/apache/cordova-android/pull/1100#issuecomment-874567483
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1100](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1a6bfee) into [master](https://codecov.io/gh/apache/cordova-android/commit/69b24dbf6a0e33d2a9ee360a464c2abf2568d661?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (69b24db) will **increase** coverage by `0.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
+ Coverage 71.08% 71.64% +0.55%
==========================================
Files 22 21 -1
Lines 1705 1654 -51
==========================================
- Hits 1212 1185 -27
+ Misses 493 469 -24
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL2xpYi9jcmVhdGUuanM=) | `94.59% <ø> (-0.31%)` | :arrow_down: |
| [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `39.39% <ø> (+6.06%)` | :arrow_up: |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `96.55% <ø> (-1.01%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [69b24db...1a6bfee](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on pull request #1100: refactor!: remove platform binaries
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #1100:
URL: https://github.com/apache/cordova-android/pull/1100#issuecomment-713293091
Everything seems fine but had only 1 question:
* `android_sdk_version`, which was removed, seems to be called from [cordova-lib](https://github.com/apache/cordova-lib/blob/master/src/plugman/util/default-engines.js#L47). Can it be confirmed that this code in lib is not called in the CLI workflow?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1100: refactor!: remove most platform binaries
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1100:
URL: https://github.com/apache/cordova-android/pull/1100#issuecomment-874567483
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1100](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1a6bfee) into [master](https://codecov.io/gh/apache/cordova-android/commit/69b24dbf6a0e33d2a9ee360a464c2abf2568d661?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (69b24db) will **increase** coverage by `0.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
+ Coverage 71.08% 71.64% +0.55%
==========================================
Files 22 21 -1
Lines 1705 1654 -51
==========================================
- Hits 1212 1185 -27
+ Misses 493 469 -24
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL2xpYi9jcmVhdGUuanM=) | `94.59% <ø> (-0.31%)` | :arrow_down: |
| [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `39.39% <ø> (+6.06%)` | :arrow_up: |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `96.55% <ø> (-1.01%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [69b24db...1a6bfee](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] raphinesse commented on pull request #1100: refactor!: remove platform binaries
Posted by GitBox <gi...@apache.org>.
raphinesse commented on pull request #1100:
URL: https://github.com/apache/cordova-android/pull/1100#issuecomment-713428555
> `android_sdk_version`, which was removed, seems to be called from [cordova-lib](https://github.com/apache/cordova-lib/blob/master/src/plugman/util/default-engines.js#L47). Can it be confirmed that this code in lib is not called in the CLI workflow?
Good catch! Unfortunately this _is_ called during plugin installation as part of the check for the [`<engine>` requirement](https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#engines-and-engine) that can be specified in `plugin.xml`.
We will have to keep that too for now. In the long run we should probably change how lib delegates this task to the platforms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1100: refactor!: remove most platform binaries
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1100:
URL: https://github.com/apache/cordova-android/pull/1100#issuecomment-874567483
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1100](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1a6bfee) into [master](https://codecov.io/gh/apache/cordova-android/commit/69b24dbf6a0e33d2a9ee360a464c2abf2568d661?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (69b24db) will **increase** coverage by `0.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
+ Coverage 71.08% 71.64% +0.55%
==========================================
Files 22 21 -1
Lines 1705 1654 -51
==========================================
- Hits 1212 1185 -27
+ Misses 493 469 -24
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL2xpYi9jcmVhdGUuanM=) | `94.59% <ø> (-0.31%)` | :arrow_down: |
| [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `39.39% <ø> (+6.06%)` | :arrow_up: |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `96.55% <ø> (-1.01%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [69b24db...1a6bfee](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on pull request #1100: refactor!: remove platform binaries
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1100:
URL: https://github.com/apache/cordova-android/pull/1100#issuecomment-714644401
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=h1) Report
> Merging [#1100](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/aada3e813d35be6e16156ba631cf398df55c9802?el=desc) will **increase** coverage by `0.27%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
+ Coverage 70.06% 70.34% +0.27%
==========================================
Files 20 19 -1
Lines 1784 1723 -61
==========================================
- Hits 1250 1212 -38
+ Misses 534 511 -23
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree#diff-YmluL2xpYi9jcmVhdGUuanM=) | `93.47% <ø> (-0.40%)` | :arrow_down: |
| [bin/templates/cordova/lib/android\_sdk.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9hbmRyb2lkX3Nkay5qcw==) | `100.00% <ø> (ø)` | |
| [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `39.39% <ø> (+6.06%)` | :arrow_up: |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `100.00% <ø> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.49% <0.00%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=footer). Last update [aada3e8...f3045ec](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1100: refactor!: remove most platform binaries
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1100:
URL: https://github.com/apache/cordova-android/pull/1100#issuecomment-874567483
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1100](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8f46bb) into [master](https://codecov.io/gh/apache/cordova-android/commit/69b24dbf6a0e33d2a9ee360a464c2abf2568d661?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (69b24db) will **increase** coverage by `0.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
+ Coverage 71.08% 71.64% +0.55%
==========================================
Files 22 21 -1
Lines 1705 1654 -51
==========================================
- Hits 1212 1185 -27
+ Misses 493 469 -24
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL2xpYi9jcmVhdGUuanM=) | `94.59% <ø> (-0.31%)` | :arrow_down: |
| [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `39.39% <ø> (+6.06%)` | :arrow_up: |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `96.55% <ø> (-1.01%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [69b24db...a8f46bb](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1100: refactor!: remove most platform binaries
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1100:
URL: https://github.com/apache/cordova-android/pull/1100#issuecomment-874567483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1100: refactor!: remove most platform binaries
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1100:
URL: https://github.com/apache/cordova-android/pull/1100#issuecomment-874567483
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1100](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c8c7b1a) into [master](https://codecov.io/gh/apache/cordova-android/commit/69b24dbf6a0e33d2a9ee360a464c2abf2568d661?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (69b24db) will **increase** coverage by `0.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
+ Coverage 71.08% 71.64% +0.55%
==========================================
Files 22 21 -1
Lines 1705 1654 -51
==========================================
- Hits 1212 1185 -27
+ Misses 493 469 -24
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL2xpYi9jcmVhdGUuanM=) | `94.59% <ø> (-0.31%)` | :arrow_down: |
| [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `39.39% <ø> (+6.06%)` | :arrow_up: |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `96.55% <ø> (-1.01%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [69b24db...c8c7b1a](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on pull request #1100: refactor!: remove platform binaries
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #1100:
URL: https://github.com/apache/cordova-android/pull/1100#issuecomment-820859945
@raphinesse this PR will need to be rebased and the conflicts resolved.
Other then that, were there other changes needed or is this PR ready and could be merged in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1100: refactor!: remove platform binaries
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1100:
URL: https://github.com/apache/cordova-android/pull/1100#issuecomment-714644401
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1100: refactor!: remove platform binaries
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1100:
URL: https://github.com/apache/cordova-android/pull/1100#issuecomment-714644401
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=h1) Report
> Merging [#1100](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/aada3e813d35be6e16156ba631cf398df55c9802?el=desc) will **increase** coverage by `0.27%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
+ Coverage 70.06% 70.34% +0.27%
==========================================
Files 20 19 -1
Lines 1784 1723 -61
==========================================
- Hits 1250 1212 -38
+ Misses 534 511 -23
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree#diff-YmluL2xpYi9jcmVhdGUuanM=) | `93.47% <ø> (-0.40%)` | :arrow_down: |
| [bin/templates/cordova/lib/android\_sdk.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9hbmRyb2lkX3Nkay5qcw==) | `100.00% <ø> (ø)` | |
| [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `39.39% <ø> (+6.06%)` | :arrow_up: |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `100.00% <ø> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1100/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.49% <0.00%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=footer). Last update [aada3e8...f3045ec](https://codecov.io/gh/apache/cordova-android/pull/1100?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] raphinesse commented on pull request #1100: refactor!: remove platform binaries
Posted by GitBox <gi...@apache.org>.
raphinesse commented on pull request #1100:
URL: https://github.com/apache/cordova-android/pull/1100#issuecomment-820963263
> @raphinesse this PR will need to be rebased and the conflicts resolved.
>
> Other then that, were there other changes needed or is this PR ready and could be merged in?
I'm not sure. I think at least the TODOs in the description still have to be applied. Given that the next major release of this platform is supposed to be independent from a tooling release, this would mean keeping anything that would otherwise break compatibility with current tooling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org