[jira] [Created] (SOLR-5696) ConcurrentUpdateSolrServer.shutdown() should flush queue first

["David Smiley (JIRA)" <ji...@apache.org>]

David Smiley created SOLR-5696:
----------------------------------

             Summary: ConcurrentUpdateSolrServer.shutdown() should flush queue first
                 Key: SOLR-5696
                 URL: https://issues.apache.org/jira/browse/SOLR-5696
             Project: Solr
          Issue Type: Improvement
          Components: clients - java
    Affects Versions: 4.6.1
            Reporter: David Smiley


The unstated semantics of SolrServer, an important SolrJ abstraction, is that you can call add(doc) some number of times and when all finished call shutdown().  Perhaps  commitWithinMs is specified or auto-commit is used on the server instead of explicit commits.

But this fails for ConcurrentUpdateSolrServer and perhaps others.  It fails because ConcurrentUpdateSolrServer.shutdown() shuts down the http connection as first order of business before shutting down the queue.  I think it should first call blockUntilFinished(), then shutdown the scheduler, and finally shutdown the http connection.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org