You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2022/01/10 11:55:06 UTC
[kudu-CR] [asan] improve asan success rate, k6s context init and destroy
shenxingwuying@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18135
Change subject: [asan] improve asan success rate, k6s context init and destroy
......................................................................
[asan] improve asan success rate, k6s context init and destroy
kerborus's init context is global, KinitContext* g_kinit_ctx,
it used new operator, but no delete operator.
It release the memory by os when program stopping.
Some asan tests may failed, when MiniCluster restart/stop.
I have encounted the scene.
Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
---
M src/kudu/security/init.cc
M src/kudu/security/init.h
M src/kudu/server/server_base.cc
3 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/18135/1
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sh...@gmail.com>
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18135 )
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
Patch Set 15: Code-Review+2
Thanks a lot for your contribution!
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 15
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 01 Feb 2022 21:57:12 +0000
Gerrit-HasComments: No
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18135
to look at the new patch set (#10).
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
[asan] improve asan success rate, kerberos context init and destroy
kerberos's init context is global, KinitContext* g_kinit_ctx,
it used new operator, but no delete operator.
It release the memory by os when program stopping.
Some asan tests may failed, when MiniCluster restart/stop.
KinitContext should be deleted safely.
Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
---
M src/kudu/security/init.cc
M src/kudu/security/init.h
M src/kudu/security/kinit_context.h
M src/kudu/server/server_base.cc
4 files changed, 67 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/18135/10
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 10
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [asan] improve asan success rate, k6s context init and destroy
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18135 )
Change subject: [asan] improve asan success rate, k6s context init and destroy
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18135/1/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:
http://gerrit.cloudera.org:8080/#/c/18135/1/src/kudu/server/server_base.cc@872
PS1, Line 872: delete security::g_kinit_ctx;
How do we know that KinitContext::DoRenewal() isn't going to be called on g_kinit_ctx after this point by the kerberos creds renewal thread created by InitKerberosForServer() ?
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Jan 2022 17:58:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18135
to look at the new patch set (#12).
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
[asan] improve asan success rate, kerberos context init and destroy
kerberos's init context is global, KinitContext* g_kinit_ctx,
it used new operator, but no delete operator.
It release the memory by os when program stopping.
Some asan tests may failed, when MiniCluster restart/stop.
KinitContext should be deleted safely.
Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
---
M src/kudu/security/init.cc
M src/kudu/security/init.h
M src/kudu/security/kinit_context.h
M src/kudu/server/server_base.cc
4 files changed, 66 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/18135/12
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 12
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18135
to look at the new patch set (#13).
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
[asan] improve asan success rate, kerberos context init and destroy
kerberos's init context is global, KinitContext* g_kinit_ctx,
it used new operator, but no delete operator.
It release the memory by os when program stopping.
Some asan tests may failed, when MiniCluster restart/stop.
KinitContext should be deleted safely.
Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
---
M src/kudu/security/init.cc
M src/kudu/security/init.h
M src/kudu/security/kinit_context.h
M src/kudu/server/server_base.cc
4 files changed, 66 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/18135/13
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 13
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18135
to look at the new patch set (#7).
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
[asan] improve asan success rate, kerberos context init and destroy
kerberos's init context is global, KinitContext* g_kinit_ctx,
it used new operator, but no delete operator.
It release the memory by os when program stopping.
Some asan tests may failed, when MiniCluster restart/stop.
KinitContext should be deleted safely.
Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/security/init.cc
M src/kudu/security/init.h
M src/kudu/security/kinit_context.h
M src/kudu/server/server_base.cc
M src/kudu/util/net/socket-test.cc
6 files changed, 68 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/18135/7
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18135 )
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h
File src/kudu/security/kinit_context.h:
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h@68
PS7, Line 68: // Periodically calls DoRenewal().
nit: private is OK
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/util/net/socket-test.cc
File src/kudu/util/net/socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/util/net/socket-test.cc@86
PS7, Line 86: SleepFor(MonoDelta::FromMilliseconds(500));
Why increase it?
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Jan 2022 16:23:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18135
to look at the new patch set (#6).
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
[asan] improve asan success rate, kerberos context init and destroy
kerberos's init context is global, KinitContext* g_kinit_ctx,
it used new operator, but no delete operator.
It release the memory by os when program stopping.
Some asan tests may failed, when MiniCluster restart/stop.
KinitContext should be deleted safely.
Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/security/init.cc
M src/kudu/security/init.h
M src/kudu/security/kinit_context.h
M src/kudu/server/server_base.cc
M src/kudu/util/net/socket-test.cc
6 files changed, 68 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/18135/6
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18135 )
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/util/net/socket-test.cc
File src/kudu/util/net/socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/util/net/socket-test.cc@86
PS7, Line 86: SleepFor(MonoDelta::FromMilliseconds(200));
> In my tests, the case is a little not stable.
ok. I have restore it.
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 9
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Sun, 30 Jan 2022 07:18:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18135 )
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
[asan] improve asan success rate, kerberos context init and destroy
kerberos's init context is global, KinitContext* g_kinit_ctx,
it used new operator, but no delete operator.
It release the memory by os when program stopping.
Some asan tests may failed, when MiniCluster restart/stop.
KinitContext should be deleted safely.
Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Reviewed-on: http://gerrit.cloudera.org:8080/18135
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/security/init.cc
M src/kudu/security/init.h
M src/kudu/security/kinit_context.h
M src/kudu/server/server_base.cc
4 files changed, 68 insertions(+), 27 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 16
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18135
to look at the new patch set (#8).
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
[asan] improve asan success rate, kerberos context init and destroy
kerberos's init context is global, KinitContext* g_kinit_ctx,
it used new operator, but no delete operator.
It release the memory by os when program stopping.
Some asan tests may failed, when MiniCluster restart/stop.
KinitContext should be deleted safely.
Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
---
M src/kudu/security/init.cc
M src/kudu/security/init.h
M src/kudu/security/kinit_context.h
M src/kudu/server/server_base.cc
M src/kudu/util/net/socket-test.cc
5 files changed, 69 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/18135/8
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 8
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [asan] improve asan success rate, k6s context init and destroy
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18135
to look at the new patch set (#4).
Change subject: [asan] improve asan success rate, k6s context init and destroy
......................................................................
[asan] improve asan success rate, k6s context init and destroy
kerborus's init context is global, KinitContext* g_kinit_ctx,
it used new operator, but no delete operator.
It release the memory by os when program stopping.
Some asan tests may failed, when MiniCluster restart/stop.
I have encounted the scene.
Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
---
M src/kudu/security/init.cc
M src/kudu/security/init.h
M src/kudu/server/server_base.cc
3 files changed, 26 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/18135/4
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18135
to look at the new patch set (#5).
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
[asan] improve asan success rate, kerberos context init and destroy
kerberus's init context is global, KinitContext* g_kinit_ctx,
it used new operator, but no delete operator.
It release the memory by os when program stopping.
Some asan tests may failed, when MiniCluster restart/stop.
KinitContext should be deleted safely.
Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/security/init.cc
M src/kudu/security/init.h
M src/kudu/security/kinit_context.h
M src/kudu/server/server_base.cc
M src/kudu/util/net/socket-test.cc
6 files changed, 66 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/18135/5
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18135 )
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
Patch Set 15:
> Uploaded patch set 14: Patch Set 13 was rebased.
I just re-based the patch on top of ee5e856b93e6efff415a81955071465dce0e2ded, resolving the merge conflicts.
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 15
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 01 Feb 2022 21:08:12 +0000
Gerrit-HasComments: No
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18135 )
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
Patch Set 8:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h
File src/kudu/security/kinit_context.h:
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h@45
PS7, Line 45: Ticket Gr
> renewal thread
Done
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h@45
PS7, Line 45: icket
> nit: delte --> destroying
yes. In security-itest.cc, a KinitContext be instantiated on the stack
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h@46
PS7, Line 46: //
> Maybe, make this method private and call it in the destructor?
Done
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h@68
PS7, Line 68: // Safe stop the renewal thread before destroying KinitContext
> nit: private is OK
Done
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h@90
PS7, Line 90:
: // To stop reacquire_thread_ when proces
> Add comments for this two fields: what are they for, what's the relation be
Done
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/util/net/socket-test.cc
File src/kudu/util/net/socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/util/net/socket-test.cc@86
PS7, Line 86: SleepFor(MonoDelta::FromMilliseconds(500));
> Why increase it?
In my tests, the case is a little not stable.
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 8
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Sun, 30 Jan 2022 07:15:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#15) to the change originally created by Yuqi Du. ( http://gerrit.cloudera.org:8080/18135 )
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
[asan] improve asan success rate, kerberos context init and destroy
kerberos's init context is global, KinitContext* g_kinit_ctx,
it used new operator, but no delete operator.
It release the memory by os when program stopping.
Some asan tests may failed, when MiniCluster restart/stop.
KinitContext should be deleted safely.
Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
---
M src/kudu/security/init.cc
M src/kudu/security/init.h
M src/kudu/security/kinit_context.h
M src/kudu/server/server_base.cc
4 files changed, 68 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/18135/15
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 15
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
shenxingwuying@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18135 )
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
Patch Set 7:
> Patch Set 5:
>
> (1 comment)
done
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 26 Jan 2022 05:44:30 +0000
Gerrit-HasComments: No
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18135 )
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
Patch Set 9:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/18135/9/src/kudu/security/init.cc
File src/kudu/security/init.cc:
http://gerrit.cloudera.org:8080/#/c/18135/9/src/kudu/security/init.cc@321
PS9, Line 321: Status
It seems the return type for this method can be changed from Status to void?
http://gerrit.cloudera.org:8080/#/c/18135/9/src/kudu/security/init.cc@323
PS9, Line 323: scoped_refptr<Thread> t = reacquire_thread_;
: if (t.get() != nullptr) {
: t->Join();
: }
Why not to use the existing 'reacquire_thread_' handle to do this? Please add a comment to explain if there is any particular reason.
http://gerrit.cloudera.org:8080/#/c/18135/9/src/kudu/security/init.cc@520
PS9, Line 520: Status
Does it make sense to update the signature of this method to return void instead of Status?
http://gerrit.cloudera.org:8080/#/c/18135/9/src/kudu/security/kinit_context.h
File src/kudu/security/kinit_context.h:
http://gerrit.cloudera.org:8080/#/c/18135/9/src/kudu/security/kinit_context.h@93
PS9, Line 93: thread for do renewals kerberos
nit: how about
A thread to renew and reacquire Kerberos credentials.
?
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/util/net/socket-test.cc
File src/kudu/util/net/socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/util/net/socket-test.cc@86
PS7, Line 86: SleepFor(MonoDelta::FromMilliseconds(200));
> ok. I have restore it.
Thank you! If you still see the instability because of this, feel free to post a separate patch to address the issue.
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 9
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 31 Jan 2022 00:43:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18135
to look at the new patch set (#11).
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
[asan] improve asan success rate, kerberos context init and destroy
kerberos's init context is global, KinitContext* g_kinit_ctx,
it used new operator, but no delete operator.
It release the memory by os when program stopping.
Some asan tests may failed, when MiniCluster restart/stop.
KinitContext should be deleted safely.
Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
---
M src/kudu/security/init.cc
M src/kudu/security/init.h
M src/kudu/security/kinit_context.h
M src/kudu/server/server_base.cc
4 files changed, 66 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/18135/11
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 11
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [asan] improve asan success rate, k6s context init and destroy
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18135
to look at the new patch set (#2).
Change subject: [asan] improve asan success rate, k6s context init and destroy
......................................................................
[asan] improve asan success rate, k6s context init and destroy
kerborus's init context is global, KinitContext* g_kinit_ctx,
it used new operator, but no delete operator.
It release the memory by os when program stopping.
Some asan tests may failed, when MiniCluster restart/stop.
I have encounted the scene.
Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
---
M src/kudu/security/init.cc
M src/kudu/security/init.h
M src/kudu/server/server_base.cc
3 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/18135/2
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [asan] improve asan success rate, k6s context init and destroy
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
shenxingwuying@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18135 )
Change subject: [asan] improve asan success rate, k6s context init and destroy
......................................................................
Patch Set 2:
(1 comment)
> Patch Set 1:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/18135/1/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:
http://gerrit.cloudera.org:8080/#/c/18135/1/src/kudu/server/server_base.cc@872
PS1, Line 872: ndif
> How do we know that KinitContext::DoRenewal() isn't going to be called on g
Yes, you are right, in RenewThread maybe encounter problem.
The stopping processes have some obscure actions. I'll think it.
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 11 Jan 2022 03:12:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18135
to look at the new patch set (#9).
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
[asan] improve asan success rate, kerberos context init and destroy
kerberos's init context is global, KinitContext* g_kinit_ctx,
it used new operator, but no delete operator.
It release the memory by os when program stopping.
Some asan tests may failed, when MiniCluster restart/stop.
KinitContext should be deleted safely.
Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
---
M src/kudu/security/init.cc
M src/kudu/security/init.h
M src/kudu/security/kinit_context.h
M src/kudu/server/server_base.cc
4 files changed, 68 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/18135/9
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 9
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18135 )
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
Patch Set 7:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/init.cc
File src/kudu/security/init.cc:
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/init.cc@171
PS7, Line 171: if (stop_latch_.count() > 0) stop_latch_.CountDown();
You don't need to check for count: it's totally fine and safe to call CountDown() on a latch when it's already 0.
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h
File src/kudu/security/kinit_context.h:
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h@45
PS7, Line 45: RenewThrea
renewal thread
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h@45
PS7, Line 45: delete
nit: delte --> destroying
KinitContext might be instantiated on the stack as well, right?
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h@46
PS7, Line 46: Status Kdestroy();
Maybe, make this method private and call it in the destructor?
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/security/kinit_context.h@90
PS7, Line 90: CountDownLatch stop_latch_;
: scoped_refptr<Thread> reacquire_thread_;
Add comments for this two fields: what are they for, what's the relation between them, etc.
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/server/server_base.cc@873
PS7, Line 873: security::DestroyKerberosForServer()
Consider wrapping this call into WARN_NOT_OK(). If logging isn't available at this point already, wrap the call into ignore_result().
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/util/net/socket-test.cc
File src/kudu/util/net/socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/18135/7/src/kudu/util/net/socket-test.cc@86
PS7, Line 86: SleepFor(MonoDelta::FromMilliseconds(500));
> Why increase it?
+1
Indeed, this change doesn't seem relevant to the essence of this changelist.
If it makes some tests more stable, it would make sense to separate this change in its own patch.
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 7
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Sat, 29 Jan 2022 19:30:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [asan] improve asan success rate, kerberos context init and destroy
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18135
to look at the new patch set (#14).
Change subject: [asan] improve asan success rate, kerberos context init and destroy
......................................................................
[asan] improve asan success rate, kerberos context init and destroy
kerberos's init context is global, KinitContext* g_kinit_ctx,
it used new operator, but no delete operator.
It release the memory by os when program stopping.
Some asan tests may failed, when MiniCluster restart/stop.
KinitContext should be deleted safely.
Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
---
M src/kudu/security/init.cc
M src/kudu/security/init.h
M src/kudu/security/kinit_context.h
M src/kudu/server/server_base.cc
4 files changed, 66 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/18135/14
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 14
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [asan] improve asan success rate, k6s context init and destroy
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18135
to look at the new patch set (#3).
Change subject: [asan] improve asan success rate, k6s context init and destroy
......................................................................
[asan] improve asan success rate, k6s context init and destroy
kerborus's init context is global, KinitContext* g_kinit_ctx,
it used new operator, but no delete operator.
It release the memory by os when program stopping.
Some asan tests may failed, when MiniCluster restart/stop.
I have encounted the scene.
Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
---
M src/kudu/security/init.cc
M src/kudu/security/init.h
M src/kudu/server/server_base.cc
3 files changed, 30 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/18135/3
--
To view, visit http://gerrit.cloudera.org:8080/18135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I76a639e35fdf951787f14e0603e73e9e19da6691
Gerrit-Change-Number: 18135
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)