You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Robert Muir <rc...@gmail.com> on 2015/02/11 13:00:39 UTC
VOTE: Remove sun.misc.Unsafe calls in RamUsageEstimator
See issue: LUCENE-6239
in my opinion, the objections here are not technical, instead similar
to objections on https://issues.apache.org/jira/browse/LUCENE-6069.
"Its my code, don't try to fix it".
The problem is, all this sheisty, platform-dependent, unsafe code,
well, its actually totally unnecessary.
Here is my +1 to remove it.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: VOTE: Remove sun.misc.Unsafe calls in RamUsageEstimator
Posted by Simon Willnauer <si...@gmail.com>.
I think we should not call unsafe unless it's a big benefit which
seems not be the case here. There are so many problems with unsafe so
I am +1 to remove.
On Wed, Feb 11, 2015 at 1:00 PM, Robert Muir <rc...@gmail.com> wrote:
> See issue: LUCENE-6239
>
> in my opinion, the objections here are not technical, instead similar
> to objections on https://issues.apache.org/jira/browse/LUCENE-6069.
> "Its my code, don't try to fix it".
>
> The problem is, all this sheisty, platform-dependent, unsafe code,
> well, its actually totally unnecessary.
>
> Here is my +1 to remove it.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: VOTE: Remove sun.misc.Unsafe calls in RamUsageEstimator
Posted by Dawid Weiss <da...@cs.put.poznan.pl>.
> If somebody has a way to detect compressed OOPS or not, I am happy to remove it!
I don't think anybody knows how to do it differently.
http://hg.openjdk.java.net/code-tools/jol/file/6df1a9b2e5da/jol-core/src/main/java/org/openjdk/jol/util/VMSupport.java#l477
D.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
RE: VOTE: Remove sun.misc.Unsafe calls in RamUsageEstimator
Posted by Uwe Schindler <uw...@thetaphi.de>.
I am fine with removing the code in Trunk, after we have reviewed that we don't actually use it!
My only problem at the moment is the "reference size". If somebody has a way to detect compressed OOPS or not, I am happy to remove it! Currently this is a -1 about the removal of the call to get "reference size", which is still relevant because compressed OOPs are a really factor that we need to have (32 bits or 64 reference pointers is something we currently care about!). The JVM guys are about making it possible to retrieve, so in my opinion, we should keep unless Java 9 offers a public way to get them!
My problems are more about crushing the JVM with un-mapping byte buffers in MMapDirectory (unfortunately, OpenJDK has no public way to do this).
Uwe
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de
> -----Original Message-----
> From: Robert Muir [mailto:rcmuir@gmail.com]
> Sent: Wednesday, February 11, 2015 1:01 PM
> To: dev@lucene.apache.org
> Subject: VOTE: Remove sun.misc.Unsafe calls in RamUsageEstimator
>
> See issue: LUCENE-6239
>
> in my opinion, the objections here are not technical, instead similar to
> objections on https://issues.apache.org/jira/browse/LUCENE-6069.
> "Its my code, don't try to fix it".
>
> The problem is, all this sheisty, platform-dependent, unsafe code, well, its
> actually totally unnecessary.
>
> Here is my +1 to remove it.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional
> commands, e-mail: dev-help@lucene.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
RE: VOTE: Remove sun.misc.Unsafe calls in RamUsageEstimator
Posted by Uwe Schindler <uw...@thetaphi.de>.
This was already solved. So no vote needed anymore.
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de
> -----Original Message-----
> From: Robert Muir [mailto:rcmuir@gmail.com]
> Sent: Wednesday, February 11, 2015 1:01 PM
> To: dev@lucene.apache.org
> Subject: VOTE: Remove sun.misc.Unsafe calls in RamUsageEstimator
>
> See issue: LUCENE-6239
>
> in my opinion, the objections here are not technical, instead similar to
> objections on https://issues.apache.org/jira/browse/LUCENE-6069.
> "Its my code, don't try to fix it".
>
> The problem is, all this sheisty, platform-dependent, unsafe code, well, its
> actually totally unnecessary.
>
> Here is my +1 to remove it.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional
> commands, e-mail: dev-help@lucene.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org