You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Stuart Hendren <no...@github.com> on 2017/06/03 12:34:34 UTC

[jclouds/jclouds] JCLOUDS-1293 Add custom IOException retry handler for AWS-EC2 (#1108)

As all methods use POST we can not use the method to determine if funciton is idempotent.
We therefore set all as idempotent to nullify that check and add a custom
IOException retry handler to determine if commands should be retried on IOException.

The custom hander extends the BackoffLimitedRetryHandler, the current handler, so all other behaviour is not affected.

This does not retry any POST methods unless it's ACTION starts with 'Describe'. These functions are idempotent, and therefore safe to retry.

See JCLOUDS-1293
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1108

-- Commit Summary --

  * JCLOUDS-1293 Add custom IOException retry handler for AWS-EC2

-- File Changes --

    M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/AWSEC2ApiMetadata.java (3)
    A providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/compute/strategy/AWSEC2IOExceptionRetryHandler.java (45)
    A providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/compute/strategy/AWSEC2IOExceptionRetryHandlerTest.java (56)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1108.patch
https://github.com/jclouds/jclouds/pull/1108.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1108

Re: [jclouds/jclouds] JCLOUDS-1293 Add custom IOException retry handler for AWS-EC2 (#1108)

Posted by Stuart Hendren <no...@github.com>.

stuarthendren commented on this pull request.



> + * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.aws.ec2.compute.strategy;
+
+import static org.testng.Assert.assertTrue;
+import static org.testng.Assert.assertFalse;
+
+import java.io.IOException;
+
+import org.jclouds.aws.reference.FormParameters;
+import org.jclouds.http.HttpCommand;
+import org.jclouds.http.HttpRequest;
+import org.testng.annotations.Test;
+
+public class AWSEC2IOExceptionRetryHandlerTest {

No problem
done

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1108#discussion_r120582080

Re: [jclouds/jclouds] JCLOUDS-1293 Add custom IOException retry handler for AWS-EC2 (#1108)

Posted by taro-秋刀鱼 <no...@github.com>.

china azure storage has different endpoint, such as EndpointSuffix=core.chinacloudapi.cn. in common, we need to set EndpointSuffix, so that the request can point to china azure storage.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1108#issuecomment-306732490

Re: [jclouds/jclouds] JCLOUDS-1293 Add custom IOException retry handler for AWS-EC2 (#1108)

Posted by Ignasi Barrera <no...@github.com>.

nacx commented on this pull request.



> + * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.aws.ec2.compute.strategy;
+
+import static org.testng.Assert.assertTrue;
+import static org.testng.Assert.assertFalse;
+
+import java.io.IOException;
+
+import org.jclouds.aws.reference.FormParameters;
+import org.jclouds.http.HttpCommand;
+import org.jclouds.http.HttpRequest;
+import org.testng.annotations.Test;
+
+public class AWSEC2IOExceptionRetryHandlerTest {

Can you annotate this test class so it belongs to the `unit` group?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1108#pullrequestreview-42226908

Re: [jclouds/jclouds] JCLOUDS-1293 Add custom IOException retry handler for AWS-EC2 (#1108)

Posted by Stuart Hendren <no...@github.com>.

This is for Amazon, not Azure. You probably need to raise your issue
elsewhere
S

On Wed, 7 Jun 2017 at 09:51 taro-秋刀鱼 <no...@github.com> wrote:

> china azure storage has different endpoint, such as EndpointSuffix=
> core.chinacloudapi.cn. in common, we need to set EndpointSuffix, so that
> the request can point to china azure storage.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/jclouds/jclouds/pull/1108#issuecomment-306732490>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AACbmTy9VoP373tDePrkWKFB_g1gD5wUks5sBmSqgaJpZM4NvEqe>
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1108#issuecomment-306746870

Re: [jclouds/jclouds] JCLOUDS-1293 Add custom IOException retry handler for AWS-EC2 (#1108)

Posted by Ignasi Barrera <no...@github.com>.

Closed #1108.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1108#event-1113384460

Re: [jclouds/jclouds] JCLOUDS-1293 Add custom IOException retry handler for AWS-EC2 (#1108)

Posted by Ignasi Barrera <no...@github.com>.

Pushed to master as [5113be22](http://git-wip-us.apache.org/repos/asf/jclouds/commit/5113be22). Thanks @stuarthendren!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1108#issuecomment-306754214