You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Kurt Deschler (Code Review)" <ge...@cloudera.org> on 2021/02/24 20:52:47 UTC

[Impala-ASF-CR] IMPALA-10522: Support external use of frontend libraries

Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17115

to look at the new patch set (#3).

Change subject: IMPALA-10522: Support external use of frontend libraries
......................................................................

IMPALA-10522: Support external use of frontend libraries

This patch enables the Impala frontend jar and dependent library
libfesupport.so to be used by an external Java frontend.

A flag has been added to FeSupport.loadLibrary() that changes
initialization of specific frontend components. This mode builds upon
logic that is used to initialize the frontend jar for unit tests.

Initialization differs in external mode as follows:

- Skip instantiating Frontend object and it's dependents
- Skip loading libhdfs
- Skip starting JVM Pause monitor
- Disable Minidumper
- Initialize TimezoneDatabase for external frontends

Null check were added in places where objects were assumed to be
instantiated but are now skipped during initialization.

Additional change:
1) Add libfesupport.lib path to JAVA_LIBRARY_PATH in test driver

Testing: - Initialized frontend jar from external frontend
 - Verified that frontend Java objects can be used externally without
   issues
 - Verified that exceptions thrown from Impala Java or libfesupport
   can be caught or propagated correctly by the external frontend

Co-author: John Sherman <jf...@cloudera.com>
Co-author: Aman Sinha <am...@cloudera.com>

Change-Id: I4e3a84721ba196ec00773ce2923b19610b90edd9
---
M be/src/common/init.cc
M be/src/common/init.h
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
M be/src/service/fe-support.cc
M be/src/util/jni-util.cc
M fe/src/main/java/org/apache/impala/service/FeSupport.java
M testdata/bin/run-hive-server.sh
8 files changed, 61 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/17115/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e3a84721ba196ec00773ce2923b19610b90edd9
Gerrit-Change-Number: 17115
Gerrit-PatchSet: 3
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>