You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "silver-ymz (via GitHub)" <gi...@apache.org> on 2023/06/29 02:00:29 UTC

[GitHub] [incubator-opendal] silver-ymz opened a new pull request, #2566: doc(bindings/haskell): add module document

silver-ymz opened a new pull request, #2566:
URL: https://github.com/apache/incubator-opendal/pull/2566

   Update:
   - add some module documents in `OpenDAL.hs`
   - apply `hlint` suggestions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] suyanhanx commented on a diff in pull request #2566: doc(bindings/haskell): add module document

Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on code in PR #2566:
URL: https://github.com/apache/incubator-opendal/pull/2566#discussion_r1246028905


##########
bindings/haskell/README.md:
##########
@@ -34,3 +35,15 @@ If you don't want to install `libopendal_hs`, you need to specify library path m
 ```bash
 LIBRARY_PATH=... cabal build
 ```
+
+## Test
+
+```bash
+LD_LIBRARY_PATH=... cabal test
+```
+
+## Doc

Review Comment:
   Maybe we should provide a way to visit the docs here?
   Just tell user to generate the doc, it's not suitable here.
   
   We can do the same with other bindings. It can be done in another PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] Xuanwo merged pull request #2566: doc(bindings/haskell): add module document

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #2566:
URL: https://github.com/apache/incubator-opendal/pull/2566


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] silver-ymz commented on a diff in pull request #2566: doc(bindings/haskell): add module document

Posted by "silver-ymz (via GitHub)" <gi...@apache.org>.
silver-ymz commented on code in PR #2566:
URL: https://github.com/apache/incubator-opendal/pull/2566#discussion_r1246038605


##########
bindings/haskell/README.md:
##########
@@ -34,3 +35,15 @@ If you don't want to install `libopendal_hs`, you need to specify library path m
 ```bash
 LIBRARY_PATH=... cabal build
 ```
+
+## Test
+
+```bash
+LD_LIBRARY_PATH=... cabal test
+```
+
+## Doc

Review Comment:
   I have added some explanations about visiting documents in the new commit. About github action for it, I'd like to complete it in another PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] oowl commented on a diff in pull request #2566: doc(bindings/haskell): add module document

Posted by "oowl (via GitHub)" <gi...@apache.org>.
oowl commented on code in PR #2566:
URL: https://github.com/apache/incubator-opendal/pull/2566#discussion_r1246032653


##########
bindings/haskell/README.md:
##########
@@ -34,3 +35,15 @@ If you don't want to install `libopendal_hs`, you need to specify library path m
 ```bash
 LIBRARY_PATH=... cabal build
 ```
+
+## Test
+
+```bash
+LD_LIBRARY_PATH=... cabal test
+```
+
+## Doc

Review Comment:
   Yeah, just like this PR https://github.com/apache/incubator-opendal/pull/2549/files#diff-9cf2000c53760d837a449f874e53f792819108d3a4bf346336d0f7d082deae2c, add GitHub action for generate and publish doc to GitHub pages.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org