You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by kl0u <gi...@git.apache.org> on 2017/10/16 13:49:26 UTC
[GitHub] flink pull request #4838: [FLINK-7826][QS] Add support for all types of stat...
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/4838
[FLINK-7826][QS] Add support for all types of state to the QS Client.
## What is the purpose of the change
As the JIRA describes, it makes the queryable state client able to query all types of Flink state, as long as the user provides the adequate state descriptor.
## Verifying this change
This change added tests in the `AbstractQueryableStateITCase` and the `org.apache.flink.queryablestate.state` package.
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? JavaDocs / and pending documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink qs-all-state-support
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4838.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4838
----
commit 9d2c02f5d90dcbb78a9aae8748f2ad58d9dc6354
Author: kkloudas <kk...@gmail.com>
Date: 2017-10-10T14:40:57Z
[FLINK-7826][QS] Add support for all types of state to the QS Client.
----
---
[GitHub] flink issue #4838: [FLINK-7826][QS] Add support for all types of state to th...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/4838
R @aljoscha
---
[GitHub] flink pull request #4838: [FLINK-7826][QS] Add support for all types of stat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4838
---
[GitHub] flink pull request #4838: [FLINK-7826][QS] Add support for all types of stat...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4838#discussion_r145326904
--- Diff: flink-queryable-state/flink-queryable-state-java/src/test/java/org/apache/flink/queryablestate/state/ImmutableAggregatingStateTest.java ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.queryablestate.state;
+
+import org.apache.flink.api.common.ExecutionConfig;
+import org.apache.flink.api.common.functions.AggregateFunction;
+import org.apache.flink.api.common.state.AggregatingStateDescriptor;
+import org.apache.flink.core.memory.DataOutputViewStreamWrapper;
+import org.apache.flink.queryablestate.client.state.ImmutableAggregatingState;
+
+import org.junit.Before;
+import org.junit.Test;
+
+import java.io.ByteArrayOutputStream;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Tests the {@link ImmutableAggregatingStateTest}.
--- End diff --
typo, should be `ImmutableAggregatingState`
---