You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2012/04/23 03:31:33 UTC
[jira] [Created] (LUCENE-4013) DWPTpool shouldnt be public (its
methods have pkg-private parameters)
Robert Muir created LUCENE-4013:
-----------------------------------
Summary: DWPTpool shouldnt be public (its methods have pkg-private parameters)
Key: LUCENE-4013
URL: https://issues.apache.org/jira/browse/LUCENE-4013
Project: Lucene - Java
Issue Type: Task
Components: core/index
Reporter: Robert Muir
Fix For: 4.0
So you really need to be in the o.a.l.index package anyway...
Can we just make this pkg-private?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4013) DWPTpool shouldnt be public (its
methods have pkg-private parameters)
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259856#comment-13259856 ]
Robert Muir commented on LUCENE-4013:
-------------------------------------
+1
> DWPTpool shouldnt be public (its methods have pkg-private parameters)
> ---------------------------------------------------------------------
>
> Key: LUCENE-4013
> URL: https://issues.apache.org/jira/browse/LUCENE-4013
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index
> Reporter: Robert Muir
> Fix For: 4.0
>
> Attachments: LUCENE-4013.patch, LUCENE-4013.patch
>
>
> So you really need to be in the o.a.l.index package anyway...
> Can we just make this pkg-private?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4013) DWPTpool shouldnt be public (its
methods have pkg-private parameters)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259774#comment-13259774 ]
Michael McCandless commented on LUCENE-4013:
--------------------------------------------
How about simply removing this from IWC?
It's such an insanely expert thing that anyone wanting to experiment with it can modify Lucene's sources (and submit a patch back if the results are good)...
> DWPTpool shouldnt be public (its methods have pkg-private parameters)
> ---------------------------------------------------------------------
>
> Key: LUCENE-4013
> URL: https://issues.apache.org/jira/browse/LUCENE-4013
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index
> Reporter: Robert Muir
> Fix For: 4.0
>
>
> So you really need to be in the o.a.l.index package anyway...
> Can we just make this pkg-private?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4013) DWPTpool shouldnt be public (its
methods have pkg-private parameters)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-4013:
---------------------------------------
Attachment: LUCENE-4013.patch
Patch, just making the IWC set/get package private, and fixing LTC to use reflection to gain access...
> DWPTpool shouldnt be public (its methods have pkg-private parameters)
> ---------------------------------------------------------------------
>
> Key: LUCENE-4013
> URL: https://issues.apache.org/jira/browse/LUCENE-4013
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index
> Reporter: Robert Muir
> Fix For: 4.0
>
> Attachments: LUCENE-4013.patch
>
>
> So you really need to be in the o.a.l.index package anyway...
> Can we just make this pkg-private?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4013) DWPTpool shouldnt be public (its
methods have pkg-private parameters)
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259338#comment-13259338 ]
Robert Muir commented on LUCENE-4013:
-------------------------------------
I made getAndLock pkg-private (since its effectively is anyway, does no harm),
in r1329024 to fix the broken javadocs links... but we should figure out what we want to do here
for a real fix.
> DWPTpool shouldnt be public (its methods have pkg-private parameters)
> ---------------------------------------------------------------------
>
> Key: LUCENE-4013
> URL: https://issues.apache.org/jira/browse/LUCENE-4013
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index
> Reporter: Robert Muir
> Fix For: 4.0
>
>
> So you really need to be in the o.a.l.index package anyway...
> Can we just make this pkg-private?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4013) DWPTpool shouldnt be public (its
methods have pkg-private parameters)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-4013:
---------------------------------------
Attachment: LUCENE-4013.patch
New patch, making a few more classes package private...
> DWPTpool shouldnt be public (its methods have pkg-private parameters)
> ---------------------------------------------------------------------
>
> Key: LUCENE-4013
> URL: https://issues.apache.org/jira/browse/LUCENE-4013
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index
> Reporter: Robert Muir
> Fix For: 4.0
>
> Attachments: LUCENE-4013.patch, LUCENE-4013.patch
>
>
> So you really need to be in the o.a.l.index package anyway...
> Can we just make this pkg-private?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4013) DWPTpool shouldnt be public (its
methods have pkg-private parameters)
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259337#comment-13259337 ]
Robert Muir commented on LUCENE-4013:
-------------------------------------
The problem is this guy is configurable via IndexWriterConfig too. Maybe the IWConfig getter/setter here
should also be pkg-private?
This seems pretty expert to expose publicly? We could then also make ThreadAffinityDWPTpool pkg-private too.
> DWPTpool shouldnt be public (its methods have pkg-private parameters)
> ---------------------------------------------------------------------
>
> Key: LUCENE-4013
> URL: https://issues.apache.org/jira/browse/LUCENE-4013
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index
> Reporter: Robert Muir
> Fix For: 4.0
>
>
> So you really need to be in the o.a.l.index package anyway...
> Can we just make this pkg-private?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-4013) DWPTpool shouldnt be public (its
methods have pkg-private parameters)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-4013.
----------------------------------------
Resolution: Fixed
Assignee: Michael McCandless
> DWPTpool shouldnt be public (its methods have pkg-private parameters)
> ---------------------------------------------------------------------
>
> Key: LUCENE-4013
> URL: https://issues.apache.org/jira/browse/LUCENE-4013
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index
> Reporter: Robert Muir
> Assignee: Michael McCandless
> Fix For: 4.0
>
> Attachments: LUCENE-4013.patch, LUCENE-4013.patch
>
>
> So you really need to be in the o.a.l.index package anyway...
> Can we just make this pkg-private?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org