You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/29 09:34:41 UTC

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4992: Add MergeEngine to decouple merge and rules

terrymanu opened a new pull request #4992: Add MergeEngine to decouple merge and rules
URL: https://github.com/apache/incubator-shardingsphere/pull/4992
 
 
   For #3691.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4992: Add MergeEngine to decouple merge and rules

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4992: Add MergeEngine to decouple merge and rules
URL: https://github.com/apache/incubator-shardingsphere/pull/4992
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4992: Add MergeEngine to decouple merge and rules

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4992: Add MergeEngine to decouple merge and rules
URL: https://github.com/apache/incubator-shardingsphere/pull/4992#issuecomment-605612268
 
 
   ## Pull Request Test Coverage Report for [Build 10685](https://coveralls.io/builds/29687799)
   
   * **49** of **103**   **(47.57%)**  changed or added relevant lines in **19** files are covered.
   * **1** unchanged line in **1** file lost coverage.
   * Overall coverage decreased (**-0.1%**) to **57.394%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingPreparedStatement.java](https://coveralls.io/builds/29687799/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShardingPreparedStatement.java#L135) | 9 | 10 | 90.0%
   | [sharding-proxy/sharding-proxy-bootstrap/src/main/java/org/apache/shardingsphere/shardingproxy/Bootstrap.java](https://coveralls.io/builds/29687799/source?filename=sharding-proxy%2Fsharding-proxy-bootstrap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2FBootstrap.java#L104) | 0 | 2 | 0.0%
   | [shardingsphere-underlying/shardingsphere-route/src/main/java/org/apache/shardingsphere/underlying/route/DataNodeRouter.java](https://coveralls.io/builds/29687799/source?filename=shardingsphere-underlying%2Fshardingsphere-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Froute%2FDataNodeRouter.java#L62) | 0 | 2 | 0.0%
   | [encrypt-core/encrypt-core-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/EncryptResultDecoratorEngine.java](https://coveralls.io/builds/29687799/source?filename=encrypt-core%2Fencrypt-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmerge%2FEncryptResultDecoratorEngine.java#L38) | 0 | 3 | 0.0%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/JDBCDatabaseCommunicationEngine.java](https://coveralls.io/builds/29687799/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2FJDBCDatabaseCommunicationEngine.java#L131) | 0 | 3 | 0.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingStatement.java](https://coveralls.io/builds/29687799/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShardingStatement.java#L111) | 16 | 20 | 80.0%
   | [shardingsphere-underlying/shardingsphere-merge/src/main/java/org/apache/shardingsphere/underlying/merge/MergeEntry.java](https://coveralls.io/builds/29687799/source?filename=shardingsphere-underlying%2Fshardingsphere-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fmerge%2FMergeEntry.java#L63) | 0 | 4 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/segment/table/TablesContext.java](https://coveralls.io/builds/29687799/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fsegment%2Ftable%2FTablesContext.java#L81) | 3 | 8 | 37.5%
   | [shardingsphere-underlying/shardingsphere-pluggable/src/main/java/org/apache/shardingsphere/underlying/pluggble/merge/MergeEngine.java](https://coveralls.io/builds/29687799/source?filename=shardingsphere-underlying%2Fshardingsphere-pluggable%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fpluggble%2Fmerge%2FMergeEngine.java#L43) | 0 | 6 | 0.0%
   | [shardingsphere-underlying/shardingsphere-merge/src/main/java/org/apache/shardingsphere/underlying/merge/registry/ResultProcessEngineRegistry.java](https://coveralls.io/builds/29687799/source?filename=shardingsphere-underlying%2Fshardingsphere-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fmerge%2Fregistry%2FResultProcessEngineRegistry.java#L36) | 0 | 11 | 0.0%
   <!-- | **Total:** | **49** | **103** | **47.57%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-proxy/sharding-proxy-bootstrap/src/main/java/org/apache/shardingsphere/shardingproxy/Bootstrap.java](https://coveralls.io/builds/29687799/source?filename=sharding-proxy%2Fsharding-proxy-bootstrap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2FBootstrap.java#L106) | 1 | 0% |
   <!-- | **Total:** | **1** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29687799/badge)](https://coveralls.io/builds/29687799) |
   | :-- | --: |
   | Change from base [Build 10684](https://coveralls.io/builds/29685725): |  -0.1% |
   | Covered Lines: | 11737 |
   | Relevant Lines: | 20450 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services