[jira] [Commented] (FLINK-8726) Code highlighting partially broken

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452037#comment-16452037 ] 

ASF GitHub Bot commented on FLINK-8726:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5909

    [FLINK-8726][docs] Fix and normalize code-highlighting

    ## What is the purpose of the change
    
    This PR fixes the code-highlighting that was broken when the build dependencies were bumped. Additionally it normalizes all code/text highlighting to use the `{% highlight <language> %}` syntax.
    
    ## Verifying this change
    
    Manually verified.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8726

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5909.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5909
    
----
commit 4e86f33ed6a4757a496a98f2883e3d85f85ffbdb
Author: zentol <ch...@...>
Date:   2018-04-25T10:29:08Z

    [FLINK-8726][docs] Fix and normalize code-highlighting

----


> Code highlighting partially broken
> ----------------------------------
>
>                 Key: FLINK-8726
>                 URL: https://issues.apache.org/jira/browse/FLINK-8726
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Priority: Trivial
>             Fix For: 1.5.0
>
>
> With the recent changes around the documentation build dependencies code highlighting is no longer fully working.
> Sections as below are rendered without any background [like here|https://ci.apache.org/projects/flink/flink-docs-master/dev/stream/operators/windows.html].
> {code}
> ~~~bash
> # get the hadoop2 package from the Flink download page at
> # {{ site.download_url }}
> curl -O <flink_hadoop2_download_url>
> tar xvzf flink-{{ site.version }}-bin-hadoop2.tgz
> cd flink-{{ site.version }}/
> ./bin/flink run -m yarn-cluster -yn 4 -yjm 1024 -ytm 4096 ./examples/batch/WordCount.jar
> ~~~
> {code}
> Sections using the {{\{% highlight java %}}} syntax are still working.
> We may have to do a sweep over the docs and port all code sections to the working syntax.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)