You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2011/08/20 00:37:45 UTC

Review Request: HIVE-2398 : generate schema for 'set' command resultset

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1605/
-----------------------------------------------------------

Review request for hive and Carl Steinbach.


Summary
-------

The Hive server currently has the framework to process the Cli commands like 'set'. But it returns an empty schema definition for these resultsets. The patch here is to add a getSchema() to the CommandResponse interface. The SetProcessor is modified to build a schema object which is returned with getSchema.
HiveServer is modified to call the getSchema for command cases as well.


This addresses bug HIVE-2398.
    https://issues.apache.org/jira/browse/HIVE-2398


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorResponse.java 4f7f472 
  ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 97fa1ab 
  service/src/java/org/apache/hadoop/hive/service/HiveServer.java c4b041f 

Diff: https://reviews.apache.org/r/1605/diff


Testing
-------

Tested with ODBC program to execute the set command. Ran Hive unit tests.


Thanks,

Prasad

Re: Review Request: HIVE-2398 : generate schema for 'set' command resultset

Posted by Carl Steinbach <ca...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1605/#review1895
-----------------------------------------------------------



jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java
<https://reviews.apache.org/r/1605/#comment4376>

    Need to assert that the size of the resultset is > 0. Might also be good to log the contents of the resultset.


- Carl


On 2011-09-13 20:03:48, Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1605/
> -----------------------------------------------------------
> 
> (Updated 2011-09-13 20:03:48)
> 
> 
> Review request for hive and Carl Steinbach.
> 
> 
> Summary
> -------
> 
> The Hive server currently has the framework to process the Cli commands like 'set'. But it returns an empty schema definition for these resultsets. The patch here is to add a getSchema() to the CommandResponse interface. The SetProcessor is modified to build a schema object which is returned with getSchema.
> HiveServer is modified to call the getSchema for command cases as well.
> 
> 
> This addresses bug HIVE-2398.
>     https://issues.apache.org/jira/browse/HIVE-2398
> 
> 
> Diffs
> -----
> 
>   jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java e744d11 
>   ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorResponse.java 4f7f472 
>   ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 9ca5ca4 
>   service/src/java/org/apache/hadoop/hive/service/HiveServer.java 95f322a 
> 
> Diff: https://reviews.apache.org/r/1605/diff
> 
> 
> Testing
> -------
> 
> Tested with ODBC program to execute the set command. Ran Hive unit tests.
> 
> 
> Thanks,
> 
> Prasad
> 
>

Re: Review Request: HIVE-2398 : generate schema for 'set' command resultset

Posted by Carl Steinbach <ca...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1605/#review1903
-----------------------------------------------------------

Ship it!


+1. Will commit if tests pass.

- Carl


On 2011-09-14 19:41:13, Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1605/
> -----------------------------------------------------------
> 
> (Updated 2011-09-14 19:41:13)
> 
> 
> Review request for hive and Carl Steinbach.
> 
> 
> Summary
> -------
> 
> The Hive server currently has the framework to process the Cli commands like 'set'. But it returns an empty schema definition for these resultsets. The patch here is to add a getSchema() to the CommandResponse interface. The SetProcessor is modified to build a schema object which is returned with getSchema.
> HiveServer is modified to call the getSchema for command cases as well.
> 
> 
> This addresses bug HIVE-2398.
>     https://issues.apache.org/jira/browse/HIVE-2398
> 
> 
> Diffs
> -----
> 
>   jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java e744d11 
>   ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorResponse.java 4f7f472 
>   ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 9ca5ca4 
>   service/src/java/org/apache/hadoop/hive/service/HiveServer.java 95f322a 
> 
> Diff: https://reviews.apache.org/r/1605/diff
> 
> 
> Testing
> -------
> 
> Tested with ODBC program to execute the set command. Ran Hive unit tests.
> 
> 
> Thanks,
> 
> Prasad
> 
>

Re: Review Request: HIVE-2398 : generate schema for 'set' command resultset

Posted by Prasad Mujumdar <pr...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1605/
-----------------------------------------------------------

(Updated 2011-09-14 19:41:13.647029)

Review request for hive and Carl Steinbach.

Changes
-------

Added check for resultset non empty.
The full "set -v" output would be too long, also most of the rows will different in each test setup. Hence I am suggesting not to do that. Let me know if you disagree.

Summary
-------

The Hive server currently has the framework to process the Cli commands like 'set'. But it returns an empty schema definition for these resultsets. The patch here is to add a getSchema() to the CommandResponse interface. The SetProcessor is modified to build a schema object which is returned with getSchema.
HiveServer is modified to call the getSchema for command cases as well.

This addresses bug HIVE-2398.
https://issues.apache.org/jira/browse/HIVE-2398

Diffs (updated)
-----

jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java e744d11
ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorResponse.java 4f7f472
ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 9ca5ca4
service/src/java/org/apache/hadoop/hive/service/HiveServer.java 95f322a

Diff: https://reviews.apache.org/r/1605/diff

Testing
-------

Tested with ODBC program to execute the set command. Ran Hive unit tests.

Thanks,

Prasad

Re: Review Request: HIVE-2398 : generate schema for 'set' command resultset

Posted by Prasad Mujumdar <pr...@cloudera.com>.

(Updated 2011-09-13 20:03:48.343559)

Review request for hive and Carl Steinbach.

Changes
-------

Changes per review comments.
Added a JDBC test.

The CLI behaviour does look like a but. The JDBC and ODBC client are working fine, but CLI is not printing the header. I will go ahead and log a separate Jira for that.

Summary
-------

This addresses bug HIVE-2398.
https://issues.apache.org/jira/browse/HIVE-2398

Diffs (updated)
-----

Diff: https://reviews.apache.org/r/1605/diff

Testing
-------

Tested with ODBC program to execute the set command. Ran Hive unit tests.

Thanks,

Prasad

Re: Review Request: HIVE-2398 : generate schema for 'set' command resultset

Posted by Carl Steinbach <ca...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1605/#review1857
-----------------------------------------------------------


Please add a testcase. Also, I tried running 'set -v' from the CLI after setting hive.cli.print.header=true, and I don't see the column name in the output. This seems like a bug?


ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java
<https://reviews.apache.org/r/1605/#comment4245>

    Checkstyle: static final variable names should appear in ALL CAPS



ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java
<https://reviews.apache.org/r/1605/#comment4248>

    bld? Might be good to change the name to getSchema. Also, since setColName is a constant there's no need for this method to have an input parameter.



ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java
<https://reviews.apache.org/r/1605/#comment4247>

    Please add static imports for STRING_TYPE_NAME, SERIALIZATION_NULL_FORMAT, and defaultNullString.



service/src/java/org/apache/hadoop/hive/service/HiveServer.java
<https://reviews.apache.org/r/1605/#comment4249>

    This comment is no longer valid. Also, it might be cleaner to remove the else clause.


- Carl


On 2011-08-19 22:37:45, Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1605/
> -----------------------------------------------------------
> 
> (Updated 2011-08-19 22:37:45)
> 
> 
> Review request for hive and Carl Steinbach.
> 
> 
> Summary
> -------
> 
> The Hive server currently has the framework to process the Cli commands like 'set'. But it returns an empty schema definition for these resultsets. The patch here is to add a getSchema() to the CommandResponse interface. The SetProcessor is modified to build a schema object which is returned with getSchema.
> HiveServer is modified to call the getSchema for command cases as well.
> 
> 
> This addresses bug HIVE-2398.
>     https://issues.apache.org/jira/browse/HIVE-2398
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorResponse.java 4f7f472 
>   ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 97fa1ab 
>   service/src/java/org/apache/hadoop/hive/service/HiveServer.java c4b041f 
> 
> Diff: https://reviews.apache.org/r/1605/diff
> 
> 
> Testing
> -------
> 
> Tested with ODBC program to execute the set command. Ran Hive unit tests.
> 
> 
> Thanks,
> 
> Prasad
> 
>