You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/14 00:22:04 UTC

Re: Review Request 65875: Improved logging for offers and inverse offers.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65875/
-----------------------------------------------------------

(Updated June 14, 2018, 12:22 a.m.)


Review request for mesos, Gastón Kleiman and Greg Mann.


Changes
-------

Rebased.


Repository: mesos


Description
-------

Printed offer IDs and inverse offer IDs when sending out offers and
inverse offers so it is easier to match them to their ACCEPT or DECLINE
calls and removals.


Diffs (updated)
-----

  src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 


Diff: https://reviews.apache.org/r/65875/diff/3/

Changes: https://reviews.apache.org/r/65875/diff/2-3/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Re: Review Request 65875: Improved logging for offers and inverse offers.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65875/#review204750
-----------------------------------------------------------



PASS: Mesos patch 65875 was successfully built and tested.

Reviews applied: `['65995', '65975', '65976', '65640', '65875']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65875

- Mesos Reviewbot Windows


On June 14, 2018, 12:22 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65875/
> -----------------------------------------------------------
> 
> (Updated June 14, 2018, 12:22 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Printed offer IDs and inverse offer IDs when sending out offers and
> inverse offers so it is easier to match them to their ACCEPT or DECLINE
> calls and removals.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 
> 
> 
> Diff: https://reviews.apache.org/r/65875/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 65875: Improved logging for offers and inverse offers.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65875/
-----------------------------------------------------------

(Updated June 20, 2018, 5:32 a.m.)


Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.


Repository: mesos


Description
-------

Printed offer IDs and inverse offer IDs when sending out offers and
inverse offers so it is easier to match them to their ACCEPT or DECLINE
calls and removals.


Diffs
-----

  src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 


Diff: https://reviews.apache.org/r/65875/diff/3/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao