DO NOT REPLY [Bug 36257] New: - [jci] clean ups and enhancements to JaninoJavaCompiler

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=36257>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36257

           Summary: [jci] clean ups and enhancements to JaninoJavaCompiler
           Product: Commons
           Version: unspecified
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Sandbox
        AssignedTo: commons-dev@jakarta.apache.org
        ReportedBy: joerg.heinicke@gmx.de


1. Using CharArrayReader instead of ByteArrayInputStream: This avoids conversion
of chars to bytes and back (Janino uses a Reader to read from the stream).
2. Providing an implementation of Janino's ErrorHandler and WarningHandler:
Allows to get information than just CompileExceptions.
3. Iterating over the map's entry set instead of its key set: This avoids a
lookup using get(key).
4. Common formatting at least for this file: parameters prefixed with 'p',
references to instance variable prefixed with 'this'. Is there a style guide for
this project?

This patch mixes 4 issues, but each of it has only minor effects, that it is
manageable I think:
1. -2 +2 lines
2. +3 lines inside, + implementation of CompilationProblemHandlerAdapter at the end
3. -4 +3 lines
4. the rest

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org