You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "w41ter (via GitHub)" <gi...@apache.org> on 2024/03/25 07:26:22 UTC

[PR] [fix](merge-cloud) MS return KV_TXN_CONFLICT_RETRY_TIMEOUT instead of KV_TXN_CONFLICT [doris]

w41ter opened a new pull request, #32763:
URL: https://github.com/apache/doris/pull/32763

   ## Proposed changes
   
   Issue Number: close #xxx
   
   For KV_TXN_CONFLICT, we should return KV_TXN_CONFLICT_RETRY_TIMEOUT, because BE will retries the KV_TXN_CONFLICT error.
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) MS return KV_TXN_CONFLICT_RETRY_TIMEOUT instead of KV_TXN_CONFLICT [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32763:
URL: https://github.com/apache/doris/pull/32763#issuecomment-2017382732

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) MS return KV_TXN_CONFLICT_RETRY_TIMEOUT instead of KV_TXN_CONFLICT [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32763:
URL: https://github.com/apache/doris/pull/32763#issuecomment-2017377074

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) MS return KV_TXN_CONFLICT_RETRY_TIMEOUT instead of KV_TXN_CONFLICT [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32763:
URL: https://github.com/apache/doris/pull/32763#issuecomment-2017395458

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) MS return KV_TXN_CONFLICT_RETRY_TIMEOUT instead of KV_TXN_CONFLICT [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #32763:
URL: https://github.com/apache/doris/pull/32763


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) MS return KV_TXN_CONFLICT_RETRY_TIMEOUT instead of KV_TXN_CONFLICT [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32763:
URL: https://github.com/apache/doris/pull/32763#issuecomment-2017445413

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) MS return KV_TXN_CONFLICT_RETRY_TIMEOUT instead of KV_TXN_CONFLICT [doris]

Posted by "w41ter (via GitHub)" <gi...@apache.org>.
w41ter commented on PR #32763:
URL: https://github.com/apache/doris/pull/32763#issuecomment-2017377147

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) MS return KV_TXN_CONFLICT_RETRY_TIMEOUT instead of KV_TXN_CONFLICT [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32763:
URL: https://github.com/apache/doris/pull/32763#issuecomment-2018190013

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) MS return KV_TXN_CONFLICT_RETRY_TIMEOUT instead of KV_TXN_CONFLICT [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32763:
URL: https://github.com/apache/doris/pull/32763#issuecomment-2017418980

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 38607 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 6c0109e549d0ad3435729b6bf098f01a441a1297, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17601	4418	4126	4126
   q2	2118	168	150	150
   q3	11025	1234	1236	1234
   q4	10405	796	769	769
   q5	7948	3123	3068	3068
   q6	216	128	125	125
   q7	1074	588	609	588
   q8	9770	2073	2061	2061
   q9	7360	6796	6761	6761
   q10	9527	3561	3671	3561
   q11	455	224	225	224
   q12	445	202	201	201
   q13	18074	2839	2828	2828
   q14	227	206	206	206
   q15	524	463	478	463
   q16	504	376	372	372
   q17	971	534	612	534
   q18	7280	6510	6464	6464
   q19	2211	1435	1490	1435
   q20	538	261	255	255
   q21	3584	2894	2887	2887
   q22	349	295	303	295
   Total cold run time: 112206 ms
   Total hot run time: 38607 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4160	4135	4098	4098
   q2	326	240	234	234
   q3	3025	2891	2849	2849
   q4	1870	1546	1531	1531
   q5	5338	5367	5386	5367
   q6	202	115	122	115
   q7	2265	1838	1815	1815
   q8	3179	3329	3297	3297
   q9	8810	8718	8739	8718
   q10	3887	3831	3822	3822
   q11	560	464	451	451
   q12	745	563	561	561
   q13	17720	2868	2901	2868
   q14	282	242	266	242
   q15	506	461	457	457
   q16	485	409	407	407
   q17	1744	1507	1509	1507
   q18	7462	7418	7093	7093
   q19	1638	1526	1531	1526
   q20	1907	1735	1717	1717
   q21	4763	4753	4693	4693
   q22	532	452	478	452
   Total cold run time: 71406 ms
   Total hot run time: 53820 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) MS return KV_TXN_CONFLICT_RETRY_TIMEOUT instead of KV_TXN_CONFLICT [doris]

Posted by "w41ter (via GitHub)" <gi...@apache.org>.
w41ter commented on PR #32763:
URL: https://github.com/apache/doris/pull/32763#issuecomment-2017393259

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) MS return KV_TXN_CONFLICT_RETRY_TIMEOUT instead of KV_TXN_CONFLICT [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32763:
URL: https://github.com/apache/doris/pull/32763#issuecomment-2017436079

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 186246 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 6c0109e549d0ad3435729b6bf098f01a441a1297, data reload: false
   
   query1	950	377	351	351
   query2	7378	2131	1937	1937
   query3	6759	222	216	216
   query4	31889	21304	21381	21304
   query5	4310	404	486	404
   query6	273	174	166	166
   query7	4629	295	303	295
   query8	222	159	173	159
   query9	9236	2275	2243	2243
   query10	555	233	256	233
   query11	15389	14236	14374	14236
   query12	131	88	82	82
   query13	1611	416	401	401
   query14	12355	11315	11275	11275
   query15	258	195	195	195
   query16	8251	270	257	257
   query17	1969	577	545	545
   query18	2119	297	277	277
   query19	368	155	155	155
   query20	92	89	87	87
   query21	206	128	126	126
   query22	5166	4884	4796	4796
   query23	33393	32824	32724	32724
   query24	10748	2857	2863	2857
   query25	606	383	382	382
   query26	1480	152	160	152
   query27	2954	345	357	345
   query28	7615	1885	1860	1860
   query29	927	683	629	629
   query30	306	149	148	148
   query31	953	742	717	717
   query32	103	59	61	59
   query33	785	335	257	257
   query34	941	481	490	481
   query35	827	609	604	604
   query36	1030	890	889	889
   query37	125	77	78	77
   query38	3483	3391	3391	3391
   query39	1466	1439	1407	1407
   query40	216	117	112	112
   query41	52	48	49	48
   query42	104	97	99	97
   query43	481	445	449	445
   query44	1131	722	720	720
   query45	287	263	252	252
   query46	1112	692	692	692
   query47	1939	1867	1854	1854
   query48	447	349	344	344
   query49	1117	344	352	344
   query50	776	369	377	369
   query51	6723	6560	6590	6560
   query52	108	99	95	95
   query53	346	277	277	277
   query54	317	247	252	247
   query55	86	78	76	76
   query56	329	246	236	236
   query57	1217	1133	1136	1133
   query58	241	210	211	210
   query59	2746	2557	2729	2557
   query60	279	244	252	244
   query61	96	93	96	93
   query62	651	446	453	446
   query63	310	277	272	272
   query64	6378	4010	4011	4010
   query65	3121	3024	3017	3017
   query66	1427	358	355	355
   query67	15273	14856	14664	14664
   query68	6723	497	510	497
   query69	613	372	379	372
   query70	1266	1217	1115	1115
   query71	489	285	278	278
   query72	6746	2741	2516	2516
   query73	737	310	314	310
   query74	8255	6609	6657	6609
   query75	4116	2926	2912	2912
   query76	4389	872	880	872
   query77	619	276	259	259
   query78	10904	10128	10162	10128
   query79	8416	509	523	509
   query80	1808	384	380	380
   query81	560	214	215	214
   query82	1619	202	207	202
   query83	315	143	163	143
   query84	292	75	82	75
   query85	1636	340	370	340
   query86	493	295	278	278
   query87	3731	3541	3492	3492
   query88	4906	2289	2298	2289
   query89	523	365	386	365
   query90	1976	180	177	177
   query91	178	148	165	148
   query92	61	49	48	48
   query93	6037	482	476	476
   query94	1202	188	180	180
   query95	454	331	329	329
   query96	602	267	267	267
   query97	3069	2877	2916	2877
   query98	223	205	211	205
   query99	1254	896	910	896
   Total cold run time: 313380 ms
   Total hot run time: 186246 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) MS return KV_TXN_CONFLICT_RETRY_TIMEOUT instead of KV_TXN_CONFLICT [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32763:
URL: https://github.com/apache/doris/pull/32763#issuecomment-2017440860

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 6c0109e549d0ad3435729b6bf098f01a441a1297 with default session variables
   Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
   Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       19.4 seconds inserted 10000000 Rows, about 515K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org