You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ro...@apache.org on 2017/10/12 22:54:52 UTC
[16/18] beam git commit: Break out the exclusion list for futurize
Break out the exclusion list for futurize
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/cf2be415
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/cf2be415
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/cf2be415
Branch: refs/heads/master
Commit: cf2be415b9b407b2d3791310a74d76b3e46fc1fa
Parents: 14cf6a1
Author: Holden Karau <ho...@us.ibm.com>
Authored: Thu Sep 7 23:38:52 2017 -0700
Committer: Robert Bradshaw <ro...@gmail.com>
Committed: Thu Oct 12 15:53:55 2017 -0700
----------------------------------------------------------------------
sdks/python/run_pylint.sh | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/beam/blob/cf2be415/sdks/python/run_pylint.sh
----------------------------------------------------------------------
diff --git a/sdks/python/run_pylint.sh b/sdks/python/run_pylint.sh
index 06f2072..4c57e75 100755
--- a/sdks/python/run_pylint.sh
+++ b/sdks/python/run_pylint.sh
@@ -83,9 +83,15 @@ done
pushd "$MODULE"
isort -p apache_beam -w 120 -y -c -ot -cs -sl ${SKIP_PARAM}
popd
+FUTURIZE_EXCLUDED=(
+ "typehints.py"
+ "pb2"
+ "trivial_infernce.py"
+)
+FUTURIZE_GREP_PARAM=$( IFS='|'; echo "${ids[*]}" )
echo "Checking for files requiring stage 1 refactoring from futurize"
futurize_results=$(futurize -j 8 --stage1 apache_beam 2>&1 |grep Refactored)
-futurize_filtered=$(echo "$futurize_results" |grep -v 'pb2\|typehints.py\|trivial_inference.py' || echo "")
+futurize_filtered=$(echo "$futurize_results" |grep -v "$FUTURIZE_GREP_PARAM" || echo "")
count=${#futurize_filtered}
if [ "$count" != "0" ]; then
echo "Some of the changes require futurize stage 1 changes."