You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <bm...@twitter.com> on 2012/08/08 20:25:45 UTC
Review Request: Small WebUI Improvements
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6472/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
This includes:
-small number formatting fixes
-hack for fixing text highlight loss (temporary increase in update delay upon text selection)
-couldn't get the table sorting to work, but left in some of the js cleanup
-added fake data alert on the dashboard
This addresses bug MESOS-252.
https://issues.apache.org/jira/browse/MESOS-252
Diffs
-----
src/webui/master/static/controllers.js 5e6be19
src/webui/master/static/dashboard.html 0d20d37
src/webui/master/static/framework.html 6661eff
src/webui/master/static/frameworks.html fa250fb
src/webui/master/static/home.html 09892cf
src/webui/master/static/slaves.html 7932ccd
Diff: https://reviews.apache.org/r/6472/diff/
Testing
-------
Local webui testing, would like to test somewhere with offers, frameworks, etc.
Thanks,
Ben Mahler
Re: Review Request: Small WebUI Improvements
Posted by Ben Mahler <be...@gmail.com>.
> On Aug. 8, 2012, 8:32 p.m., Benjamin Hindman wrote:
> > src/webui/master/static/controllers.js, line 275
> > <https://reviews.apache.org/r/6472/diff/2/?file=135745#file135745line275>
> >
> > How about calling this 'hasSelectedText' or something of this nature since this isn't actually returning the selected text.
done
> On Aug. 8, 2012, 8:32 p.m., Benjamin Hindman wrote:
> > src/webui/master/static/controllers.js, line 128
> > <https://reviews.apache.org/r/6472/diff/2/?file=135745#file135745line128>
> >
> > Let's actually kill update_index and just do the each loop here since that seems more readable (not having to know what update_index does).
done, yeah pretty useless now that I took out the diff update
now, I tried to split out the code that stores the state vs the code that computes the extra stats
> On Aug. 8, 2012, 8:32 p.m., Benjamin Hindman wrote:
> > src/webui/master/static/controllers.js, line 58
> > <https://reviews.apache.org/r/6472/diff/2/?file=135745#file135745line58>
> >
> > Let's move this down above $.event.trigger('state_updated');
done
> On Aug. 8, 2012, 8:32 p.m., Benjamin Hindman wrote:
> > src/webui/master/static/controllers.js, line 54
> > <https://reviews.apache.org/r/6472/diff/2/?file=135745#file135745line54>
> >
> > Since this isn't a "class", let's not capitalize the first letter.
done
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6472/#review10036
-----------------------------------------------------------
On Aug. 8, 2012, 9:55 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6472/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2012, 9:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This includes:
> -small number formatting fixes
> -hack for fixing text highlight loss (temporary increase in update delay upon text selection)
> -couldn't get the table sorting to work, but left in some of the js cleanup
> -added fake data alert on the dashboard
>
>
> This addresses bug MESOS-252.
> https://issues.apache.org/jira/browse/MESOS-252
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js 5e6be19
> src/webui/master/static/dashboard.html 0d20d37
> src/webui/master/static/framework.html 6661eff
> src/webui/master/static/frameworks.html fa250fb
> src/webui/master/static/home.html 09892cf
> src/webui/master/static/slaves.html 7932ccd
>
> Diff: https://reviews.apache.org/r/6472/diff/
>
>
> Testing
> -------
>
> Local webui testing, would like to test somewhere with offers, frameworks, etc.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Small WebUI Improvements
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6472/#review10036
-----------------------------------------------------------
src/webui/master/static/controllers.js
<https://reviews.apache.org/r/6472/#comment21237>
Since this isn't a "class", let's not capitalize the first letter.
src/webui/master/static/controllers.js
<https://reviews.apache.org/r/6472/#comment21241>
Let's move this down above $.event.trigger('state_updated');
src/webui/master/static/controllers.js
<https://reviews.apache.org/r/6472/#comment21242>
Let's actually kill update_index and just do the each loop here since that seems more readable (not having to know what update_index does).
src/webui/master/static/controllers.js
<https://reviews.apache.org/r/6472/#comment21239>
How about calling this 'hasSelectedText' or something of this nature since this isn't actually returning the selected text.
- Benjamin Hindman
On Aug. 8, 2012, 6:25 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6472/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2012, 6:25 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This includes:
> -small number formatting fixes
> -hack for fixing text highlight loss (temporary increase in update delay upon text selection)
> -couldn't get the table sorting to work, but left in some of the js cleanup
> -added fake data alert on the dashboard
>
>
> This addresses bug MESOS-252.
> https://issues.apache.org/jira/browse/MESOS-252
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js 5e6be19
> src/webui/master/static/dashboard.html 0d20d37
> src/webui/master/static/framework.html 6661eff
> src/webui/master/static/frameworks.html fa250fb
> src/webui/master/static/home.html 09892cf
> src/webui/master/static/slaves.html 7932ccd
>
> Diff: https://reviews.apache.org/r/6472/diff/
>
>
> Testing
> -------
>
> Local webui testing, would like to test somewhere with offers, frameworks, etc.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Small WebUI Improvements
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6472/#review10078
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Aug. 8, 2012, 9:55 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6472/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2012, 9:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This includes:
> -small number formatting fixes
> -hack for fixing text highlight loss (temporary increase in update delay upon text selection)
> -couldn't get the table sorting to work, but left in some of the js cleanup
> -added fake data alert on the dashboard
>
>
> This addresses bug MESOS-252.
> https://issues.apache.org/jira/browse/MESOS-252
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js 5e6be19
> src/webui/master/static/dashboard.html 0d20d37
> src/webui/master/static/framework.html 6661eff
> src/webui/master/static/frameworks.html fa250fb
> src/webui/master/static/home.html 09892cf
> src/webui/master/static/slaves.html 7932ccd
>
> Diff: https://reviews.apache.org/r/6472/diff/
>
>
> Testing
> -------
>
> Local webui testing, would like to test somewhere with offers, frameworks, etc.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Small WebUI Improvements
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6472/
-----------------------------------------------------------
(Updated Aug. 8, 2012, 9:55 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
This includes:
-small number formatting fixes
-hack for fixing text highlight loss (temporary increase in update delay upon text selection)
-couldn't get the table sorting to work, but left in some of the js cleanup
-added fake data alert on the dashboard
This addresses bug MESOS-252.
https://issues.apache.org/jira/browse/MESOS-252
Diffs (updated)
-----
src/webui/master/static/controllers.js 5e6be19
src/webui/master/static/dashboard.html 0d20d37
src/webui/master/static/framework.html 6661eff
src/webui/master/static/frameworks.html fa250fb
src/webui/master/static/home.html 09892cf
src/webui/master/static/slaves.html 7932ccd
Diff: https://reviews.apache.org/r/6472/diff/
Testing
-------
Local webui testing, would like to test somewhere with offers, frameworks, etc.
Thanks,
Ben Mahler