[GitHub] [hive] jcamachor commented on a change in pull request #1959: [DRAFT] Upgrade calcite to 1.25

[GitBox <gi...@apache.org>]

jcamachor commented on a change in pull request #1959:
URL: https://github.com/apache/hive/pull/1959#discussion_r583929715



##########
File path: ql/src/test/results/clientpositive/perf/tpcds30tb/tez/cbo_query15.q.out
##########
@@ -15,6 +15,6 @@ HiveSortLimit(sort0=[$0], dir0=[ASC], fetch=[100])
               HiveFilter(condition=[AND(IS NOT NULL($2), IS NOT NULL($33))])
                 HiveTableScan(table=[[default, catalog_sales]], table:alias=[catalog_sales])
             HiveProject(d_date_sk=[$0])
-              HiveFilter(condition=[AND(=($6, 2000), =($10, 2))])
+              HiveFilter(condition=[AND(=($10, 2), =($6, 2000))])

Review comment:
       The order in the filter conditions is determined by `HiveFilterSortPredicates`. This change and other similar ones could happen due to change in selectivity estimates for each of the conjuncts. We should double check that these changes are expected. ^ @zabetak fyi




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org