You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ag...@apache.org on 2022/06/23 21:57:29 UTC

[arrow-datafusion] branch master updated: simplify FilterNullJoinKeys rule (#2781)

This is an automated email from the ASF dual-hosted git repository.

agrove pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git


The following commit(s) were added to refs/heads/master by this push:
     new aed3aa46d simplify FilterNullJoinKeys rule (#2781)
aed3aa46d is described below

commit aed3aa46d98ed86c296d447ef4de676ea77c62a2
Author: Andy Grove <ag...@apache.org>
AuthorDate: Thu Jun 23 15:57:24 2022 -0600

    simplify FilterNullJoinKeys rule (#2781)
---
 datafusion/optimizer/src/filter_null_join_keys.rs | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/datafusion/optimizer/src/filter_null_join_keys.rs b/datafusion/optimizer/src/filter_null_join_keys.rs
index 11fb19996..fd2521c68 100644
--- a/datafusion/optimizer/src/filter_null_join_keys.rs
+++ b/datafusion/optimizer/src/filter_null_join_keys.rs
@@ -57,9 +57,10 @@ impl OptimizerRule for FilterNullJoinKeys {
                     if let Some((left_field, right_field)) =
                         resolve_join_key_pair(left_schema, right_schema, l, r)
                     {
-                        if left_field.is_nullable() && !right_field.is_nullable() {
+                        if left_field.is_nullable() {
                             left_filters.push(l.clone());
-                        } else if !left_field.is_nullable() && right_field.is_nullable() {
+                        }
+                        if right_field.is_nullable() {
                             right_filters.push(r.clone());
                         }
                     }