You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "iamhucong (via GitHub)" <gi...@apache.org> on 2026/09/29 03:27:10 UTC
[PR] Optimize Oracle parsing of long concatenation expressions [shardingsphere]
iamhucong opened a new pull request, #39990:
URL: https://github.com/apache/shardingsphere/pull/39990
Changes proposed in this pull request:
- Factor Oracle `predicate` alternatives to keep adaptive prediction bounded for long concatenation expressions. Tighten FLASHBACK timestamp, MODEL, and PL/SQL expression/argument boundaries without changing shared parser APIs.
- Add cold/warm 24-, 48-, and 96-operand parser regressions and a synthetic 54-field Oracle parser integration case (including six `TO_CHAR` calls).
- Use only generic Oracle grammar and synthetic SQL; this PR does not change Proxy or database protocol behavior.
Verification on this branch:
- `OracleParserTest`: 97 tests passed.
- `OracleDMLStatementVisitorTest`: 3 tests passed.
- `InternalOracleParserIT` (reactor build with `-am`): 1969 tests passed.
- Module-scoped Spotless and Checkstyle, plus repository Apache RAT: passed.
- Full `clean install` was not run; the focused parser and IT checks above cover this change.
No user-facing configuration or documentation changes are required for this parser-only optimization. Please apply an appropriate SQL parser label. This change does not establish a fix for any separate Oracle Proxy client issue.
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code (human contributor review is still required).
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed the full Maven check locally: `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e` (focused checks above passed).
- [ ] I have made corresponding changes to the documentation (not applicable: no user-facing contract change).
- [x] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version (not applicable: internal parser optimization).
- [x] I have disclosed the tool and affected files or scope for any material AI assistance, as required by the [AI-assisted contribution policy].
AI assistance disclosure: Pi coding assistant helped adapt the Oracle `BaseRule.g4`, `DMLStatement.g4`, and `PLSQL.g4` rules; create `OracleParserTest.java`; and add paired `select-expression.xml` parser IT cases. The contribution still requires human review and responsibility under project policy. No private prompts, customer data, or logs are included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize Oracle parsing of long concatenation expressions [shardingsphere]
Posted by "FlyingZC (via GitHub)" <gi...@apache.org>.
FlyingZC merged PR #39990:
URL: https://github.com/apache/shardingsphere/pull/39990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org