You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/26 19:31:39 UTC

[GitHub] [flink] rkhachatryan commented on a change in pull request #15204: [FLINK-21783] Allow extension of HeapBackend SnapshotStrategy

rkhachatryan commented on a change in pull request #15204:
URL: https://github.com/apache/flink/pull/15204#discussion_r736856052



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointableKeyedStateBackend.java
##########
@@ -45,5 +46,6 @@
      * write out a savepoint in the common/unified format.
      */
     @Nonnull
-    SavepointResources<K> savepoint() throws Exception;
+    SavepointResources<K> savepoint(long checkpointId, CheckpointOptions checkpointOptions)

Review comment:
       `checkpointId` is supposed to be used to decide whether to make an incremental or a full snapshot.
   `checkpointOptions` can be removed, you are right.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org