You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "fuchanghai (via GitHub)" <gi...@apache.org> on 2023/08/13 13:43:36 UTC

[GitHub] [dolphinscheduler] fuchanghai opened a new pull request, #14745: [fix] modify the number of core size

fuchanghai opened a new pull request, #14745:
URL: https://github.com/apache/dolphinscheduler/pull/14745

   
   ## Purpose of the pull request
   
   plz close this issue : #14744 
   
   - #14744 
   
   ## Brief change log
   modify the  number of core size
   
   
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] fuchanghai commented on pull request #14745: [fix] modify the number of core size

Posted by "fuchanghai (via GitHub)" <gi...@apache.org>.
fuchanghai commented on PR #14745:
URL: https://github.com/apache/dolphinscheduler/pull/14745#issuecomment-1676364664

   @rickchengx PTAL 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] fuchanghai commented on pull request #14745: [fix] modify the number of core size

Posted by "fuchanghai (via GitHub)" <gi...@apache.org>.
fuchanghai commented on PR #14745:
URL: https://github.com/apache/dolphinscheduler/pull/14745#issuecomment-1676536605

   > We make the core size the same with the max size to make sure the thread pool more stable
   <img width="1407" alt="image" src="https://github.com/apache/dolphinscheduler/assets/33984497/ffdfd70d-147d-4146-941f-7beda0429d10">
   <img width="1414" alt="image" src="https://github.com/apache/dolphinscheduler/assets/33984497/4b687dac-1fff-4dae-a724-c8741a84e20b">
   
   
   hi @ruanwenjun  so do we need to remove this parameter?because it is not used in the code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #14745: [fix] modify the number of core size

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on PR #14745:
URL: https://github.com/apache/dolphinscheduler/pull/14745#issuecomment-1676390344

   We make the core size the same with the max size to make sure the thread pool  more stable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] ruanwenjun closed pull request #14745: [fix] modify the number of core size

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun closed pull request #14745: [fix] modify the  number of core size
URL: https://github.com/apache/dolphinscheduler/pull/14745


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org