[accumulo] branch 2.1 updated: Add ValidationUtilTest from PR #3549

[ct...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ctubbsii pushed a commit to branch 2.1
in repository https://gitbox.apache.org/repos/asf/accumulo.git


The following commit(s) were added to refs/heads/2.1 by this push:
     new 2ec2321df8 Add ValidationUtilTest from PR #3549
2ec2321df8 is described below

commit 2ec2321df8da0c90d2836561a2d16895e9bad0b5
Author: dtspence <dt...@users.noreply.github.com>
AuthorDate: Tue Jun 27 20:52:48 2023 +0000

    Add ValidationUtilTest from PR #3549
---
 .../accumulo/core/metadata/ValidationUtilTest.java | 50 ++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/core/src/test/java/org/apache/accumulo/core/metadata/ValidationUtilTest.java b/core/src/test/java/org/apache/accumulo/core/metadata/ValidationUtilTest.java
new file mode 100644
index 0000000000..d3bc7a26a8
--- /dev/null
+++ b/core/src/test/java/org/apache/accumulo/core/metadata/ValidationUtilTest.java
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.accumulo.core.metadata;
+
+import static org.apache.accumulo.core.metadata.ValidationUtil.validateFileName;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+import java.util.Set;
+
+import org.junit.jupiter.api.Test;
+
+public class ValidationUtilTest {
+
+  @Test
+  public void testValidateFileNameSuccess() {
+    Set.of("F0001acd.rf", "F0001acd.rf_tmp").forEach(f -> validateFileName(f));
+  }
+
+  @Test
+  public void testValidateFileNameException() {
+    Set.of("", "hdfs://nn:8020/accumulo/tables/2/default_tablet/F0001acd.rf", "./F0001acd.rf",
+        "/F0001acd.rf").forEach(f -> {
+          var e = assertThrows(IllegalArgumentException.class, () -> validateFileName(f));
+          assertEquals("Provided filename (" + f + ") is empty or contains invalid characters",
+              e.getMessage());
+        });
+  }
+
+  @Test
+  public void testValidateFileNameNull() {
+    assertThrows(NullPointerException.class, () -> validateFileName(null));
+  }
+}