You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Yurii Shylov <yu...@gmail.com> on 2015/02/05 19:18:07 UTC
Review Request 30680: After deleting host,
relevant host versions are not removed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30680/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Bugs: AMBARI-9499
https://issues.apache.org/jira/browse/AMBARI-9499
Repository: ambari
Description
-------
Notes on impl:
host versions should not be removed as well as the hosts itself, they only get detached from cluster. So filtering by cluster was added to HostStackVersionProvider
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 201ebad
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 1427b4b
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 532ad33
Diff: https://reviews.apache.org/r/30680/diff/
Testing
-------
In Progress
Thanks,
Yurii Shylov
Re: Review Request 30680: After deleting host,
relevant host versions are not removed
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30680/#review72154
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 5, 2015, 6:18 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30680/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 6:18 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9499
> https://issues.apache.org/jira/browse/AMBARI-9499
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Notes on impl:
> host versions should not be removed as well as the hosts itself, they only get detached from cluster. So filtering by cluster was added to HostStackVersionProvider
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 201ebad
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 1427b4b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 532ad33
>
> Diff: https://reviews.apache.org/r/30680/diff/
>
>
> Testing
> -------
>
> In Progress
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 30680: After deleting host,
relevant host versions are not removed
Posted by Yurii Shylov <yu...@gmail.com>.
> On Фев. 5, 2015, 6:49 п.п., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java, line 170
> > <https://reviews.apache.org/r/30680/diff/1/?file=850826#file850826line170>
> >
> > Why would the cluster name be missing?
We support /api/v1/hosts which contains every host of every cluster, and even detached ones
- Yurii
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30680/#review71264
-----------------------------------------------------------
On Фев. 5, 2015, 6:18 п.п., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30680/
> -----------------------------------------------------------
>
> (Updated Фев. 5, 2015, 6:18 п.п.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9499
> https://issues.apache.org/jira/browse/AMBARI-9499
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Notes on impl:
> host versions should not be removed as well as the hosts itself, they only get detached from cluster. So filtering by cluster was added to HostStackVersionProvider
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 201ebad
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 1427b4b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 532ad33
>
> Diff: https://reviews.apache.org/r/30680/diff/
>
>
> Testing
> -------
>
> In Progress
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 30680: After deleting host,
relevant host versions are not removed
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30680/#review71264
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
<https://reviews.apache.org/r/30680/#comment116937>
Why would the cluster name be missing?
- Alejandro Fernandez
On Feb. 5, 2015, 6:18 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30680/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 6:18 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9499
> https://issues.apache.org/jira/browse/AMBARI-9499
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Notes on impl:
> host versions should not be removed as well as the hosts itself, they only get detached from cluster. So filtering by cluster was added to HostStackVersionProvider
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 201ebad
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 1427b4b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 532ad33
>
> Diff: https://reviews.apache.org/r/30680/diff/
>
>
> Testing
> -------
>
> In Progress
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 30680: After deleting host,
relevant host versions are not removed
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30680/#review72164
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Feb. 5, 2015, 1:18 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30680/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 1:18 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9499
> https://issues.apache.org/jira/browse/AMBARI-9499
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Notes on impl:
> host versions should not be removed as well as the hosts itself, they only get detached from cluster. So filtering by cluster was added to HostStackVersionProvider
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 201ebad
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 1427b4b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 532ad33
>
> Diff: https://reviews.apache.org/r/30680/diff/
>
>
> Testing
> -------
>
> In Progress
>
>
> Thanks,
>
> Yurii Shylov
>
>