[GitHub] [pulsar] Jason918 commented on a change in pull request #12438: broker resource group test optimize fail msg

[GitBox <gi...@apache.org>]

Jason918 commented on a change in pull request #12438:
URL: https://github.com/apache/pulsar/pull/12438#discussion_r733264299



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/resourcegroup/RGUsageMTAggrWaitForAllMesgsTest.java
##########
@@ -350,13 +349,10 @@ private boolean tenantRGEqualsNamespaceRG(String[] topicStrings) throws PulsarCl
             }
         }
         if ((numEqualRGs + numUnEqualRGs != numTopics) || (numEqualRGs > 0 && numUnEqualRGs > 0)) {
-            String errMesg = String.format("Found {} topics with equal RGs and {} with unequal, on {} topics",
+            String errMesg = String.format("Found %s topics with equal RGs and %s with unequal, on %s topics",
                     numEqualRGs, numUnEqualRGs, numTopics);
             throw new PulsarClientException(errMesg);
-        } else if (numEqualRGs == numTopics) {
-            return true;
-        }
-        return false;
+        } else return numEqualRGs == numTopics;

Review comment:
       Maybe put return in newline is better? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org