[jira] [Commented] (BEAM-1568) Ineffective null check in IsmFormat#structuralValue

["Davor Bonaci (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906412#comment-15906412 ] 

Davor Bonaci commented on BEAM-1568:
------------------------------------

[~tedyu], do you want to perhaps submit a fix? Would be much appreciated.

> Ineffective null check in IsmFormat#structuralValue
> ---------------------------------------------------
>
>                 Key: BEAM-1568
>                 URL: https://issues.apache.org/jira/browse/BEAM-1568
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>            Reporter: Ted Yu
>            Assignee: Davor Bonaci
>            Priority: Minor
>
> {code}
>     public Object structuralValue(IsmRecord<V> record) throws Exception {
>       checkState(record.getKeyComponents().size() == keyComponentCoders.size(),
>           "Expected the number of key component coders %s "
>           + "to match the number of key components %s.",
>           keyComponentCoders.size(), record.getKeyComponents());
>       if (record != null && consistentWithEquals()) {
> {code}
> record is de-referenced before the null check.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)