You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by "bvaradar (via GitHub)" <gi...@apache.org> on 2023/03/23 06:05:41 UTC

[GitHub] [hudi] bvaradar commented on a diff in pull request #6945: [HUDI-5026] spark orc reader

bvaradar commented on code in PR #6945:
URL: https://github.com/apache/hudi/pull/6945#discussion_r1145714301


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieBaseRelation.scala:
##########
@@ -571,6 +568,20 @@ abstract class HoodieBaseRelation(val sqlContext: SQLContext,
           val readerSchema = StructType(requiredDataSchema.structTypeSchema.fields ++ partitionSchema.fields)
 
           (parquetReader, readerSchema)
+        case HoodieFileFormat.ORC =>

Review Comment:
   @ymZhao1001 : Can you add a testcase to showcase ORC reader working successfully



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org