You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/13 15:54:01 UTC
[jira] [Commented] (FLINK-8581) Improve performance for low latency
network
[ https://issues.apache.org/jira/browse/FLINK-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362522#comment-16362522 ]
ASF GitHub Bot commented on FLINK-8581:
---------------------------------------
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5423#discussion_r167618791
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java ---
@@ -138,6 +142,12 @@
/** Channels, which notified this input gate about available data. */
private final ArrayDeque<InputChannel> inputChannelsWithData = new ArrayDeque<>();
+ /**
+ * Field guaranteeing uniqueness for inputChannelsWithData queue. Both of those fields should be unified
+ * onto one.
+ */
+ private final Set<Integer> enqueuedInputChannelsWithData = new HashSet<>();
--- End diff --
I wonder if this should not better be a `BitSet`? Do we typically expect very few enqueued channels with data from a large set of channels?
> Improve performance for low latency network
> -------------------------------------------
>
> Key: FLINK-8581
> URL: https://issues.apache.org/jira/browse/FLINK-8581
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Affects Versions: 1.5.0
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)