[GitHub] [arrow] wgtmac commented on a diff in pull request #35499: GH-35304: [C++][ORC] Support attributes conversion

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on code in PR #35499:
URL: https://github.com/apache/arrow/pull/35499#discussion_r1189998929


##########
cpp/src/arrow/adapters/orc/util.cc:
##########
@@ -1176,11 +1190,32 @@ Result<std::unique_ptr<liborc::Type>> GetOrcType(const Schema& schema) {
   for (int i = 0; i < numFields; i++) {
     const auto& field = schema.field(i);
     ARROW_ASSIGN_OR_RAISE(auto orc_subtype, GetOrcType(*field->type()));
+    SetAttributes(field, orc_subtype.get());
     out_type->addStructField(field->name(), std::move(orc_subtype));
   }
   return std::move(out_type);
 }
 
+Result<std::shared_ptr<const KeyValueMetadata>> GetFieldMetadata(
+    const liborc::Type* type) {
+  if (type == nullptr) {

Review Comment:
   I follow the same behavior here: https://github.com/apache/arrow/blob/main/cpp/src/arrow/adapters/orc/util.cc#L1078



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org