[jira] [Commented] (HDFS-4230) Listing all the current snapshottable directories

["Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542927#comment-13542927 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-4230:
----------------------------------------------

Thanks for working on this.  Some comments on the patch:

- It may not be a good idea to have SnapshottableDirectoryStatus extending HdfsFileStatus since most of the fields in HdfsFileStatus are not needed for SnapshottableDirectoryStatus.  I think SnapshottableDirectoryStatus should be similar to ContentSummary, i.e. only put snapshotNumber and snapshotQuota in it.

- In FSDirectory.unprotectedRenameTo(..), it is better to remove snapshottableDirs at the end, i.e. right before "return filesDeleted >0" since it support restoring src and dst.  BTW, is it better to move the delete logic to HDFS-4244?
                
> Listing all the current snapshottable directories
> -------------------------------------------------
>
>                 Key: HDFS-4230
>                 URL: https://issues.apache.org/jira/browse/HDFS-4230
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4230.001.patch, HDFS-4230.001.patch, HDFS-4230.002.patch
>
>
> Provide functionality to provide user with metadata about all the snapshottable directories.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira