You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2016/06/21 07:09:39 UTC
[07/10] wicket git commit: Remove useless javadocs
Remove useless javadocs
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/547a7e14
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/547a7e14
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/547a7e14
Branch: refs/heads/master
Commit: 547a7e1477dbe49975065af2d306983137d65f89
Parents: 1769d45
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Mon Jun 20 23:13:07 2016 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Mon Jun 20 23:13:07 2016 +0200
----------------------------------------------------------------------
.../feedback/ComponentFeedbackMessageFilter.java | 3 ---
.../feedback/ContainerFeedbackMessageFilter.java | 10 ++--------
.../feedback/ErrorLevelFeedbackMessageFilter.java | 3 ---
.../org/apache/wicket/feedback/FeedbackCollector.java | 3 +--
.../org/apache/wicket/feedback/FeedbackMessage.java | 6 ------
.../org/apache/wicket/feedback/FeedbackMessages.java | 3 +--
.../apache/wicket/feedback/FeedbackMessagesModel.java | 13 +------------
.../apache/wicket/markup/html/link/ResourceLink.java | 10 ----------
8 files changed, 5 insertions(+), 46 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/547a7e14/wicket-core/src/main/java/org/apache/wicket/feedback/ComponentFeedbackMessageFilter.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/feedback/ComponentFeedbackMessageFilter.java b/wicket-core/src/main/java/org/apache/wicket/feedback/ComponentFeedbackMessageFilter.java
index b8cd508..b2cc155 100644
--- a/wicket-core/src/main/java/org/apache/wicket/feedback/ComponentFeedbackMessageFilter.java
+++ b/wicket-core/src/main/java/org/apache/wicket/feedback/ComponentFeedbackMessageFilter.java
@@ -42,9 +42,6 @@ public class ComponentFeedbackMessageFilter implements IFeedbackMessageFilter
this.component = component;
}
- /**
- * @see org.apache.wicket.feedback.IFeedbackMessageFilter#accept(org.apache.wicket.feedback.FeedbackMessage)
- */
@Override
public boolean accept(FeedbackMessage message)
{
http://git-wip-us.apache.org/repos/asf/wicket/blob/547a7e14/wicket-core/src/main/java/org/apache/wicket/feedback/ContainerFeedbackMessageFilter.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/feedback/ContainerFeedbackMessageFilter.java b/wicket-core/src/main/java/org/apache/wicket/feedback/ContainerFeedbackMessageFilter.java
index 2b2eba1..065e402 100644
--- a/wicket-core/src/main/java/org/apache/wicket/feedback/ContainerFeedbackMessageFilter.java
+++ b/wicket-core/src/main/java/org/apache/wicket/feedback/ContainerFeedbackMessageFilter.java
@@ -18,6 +18,7 @@ package org.apache.wicket.feedback;
import org.apache.wicket.Component;
import org.apache.wicket.MarkupContainer;
+import org.apache.wicket.util.lang.Args;
import org.apache.wicket.util.lang.Objects;
/**
@@ -40,16 +41,9 @@ public class ContainerFeedbackMessageFilter implements IFeedbackMessageFilter
*/
public ContainerFeedbackMessageFilter(MarkupContainer container)
{
- if (container == null)
- {
- throw new IllegalArgumentException("container must be not null");
- }
- this.container = container;
+ this.container = Args.notNull(container, "container");
}
- /**
- * @see org.apache.wicket.feedback.IFeedbackMessageFilter#accept(org.apache.wicket.feedback.FeedbackMessage)
- */
@Override
public boolean accept(FeedbackMessage message)
{
http://git-wip-us.apache.org/repos/asf/wicket/blob/547a7e14/wicket-core/src/main/java/org/apache/wicket/feedback/ErrorLevelFeedbackMessageFilter.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/feedback/ErrorLevelFeedbackMessageFilter.java b/wicket-core/src/main/java/org/apache/wicket/feedback/ErrorLevelFeedbackMessageFilter.java
index 34efa67..b155212 100644
--- a/wicket-core/src/main/java/org/apache/wicket/feedback/ErrorLevelFeedbackMessageFilter.java
+++ b/wicket-core/src/main/java/org/apache/wicket/feedback/ErrorLevelFeedbackMessageFilter.java
@@ -46,9 +46,6 @@ public class ErrorLevelFeedbackMessageFilter implements IFeedbackMessageFilter
this.minimumErrorLevel = minimumErrorLevel;
}
- /**
- * @see org.apache.wicket.feedback.IFeedbackMessageFilter#accept(org.apache.wicket.feedback.FeedbackMessage)
- */
@Override
public boolean accept(FeedbackMessage message)
{
http://git-wip-us.apache.org/repos/asf/wicket/blob/547a7e14/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java b/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
index e537df3..3a3fb2e 100755
--- a/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
+++ b/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java
@@ -102,7 +102,7 @@ public class FeedbackCollector
*/
public final List<FeedbackMessage> collect(final IFeedbackMessageFilter filter)
{
- final List<FeedbackMessage> messages = new ArrayList<FeedbackMessage>();
+ final List<FeedbackMessage> messages = new ArrayList<>();
if (includeSession && Session.exists())
{
@@ -118,7 +118,6 @@ public class FeedbackCollector
{
((MarkupContainer)component).visitChildren(new IVisitor<Component, Void>()
{
-
@Override
public void component(Component object, IVisit<Void> visit)
{
http://git-wip-us.apache.org/repos/asf/wicket/blob/547a7e14/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessage.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessage.java b/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessage.java
index 69adb70..0f61401 100644
--- a/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessage.java
+++ b/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessage.java
@@ -137,7 +137,6 @@ public class FeedbackMessage implements IDetachable
return rendered;
}
-
/**
* Marks this message as rendered.
*/
@@ -146,7 +145,6 @@ public class FeedbackMessage implements IDetachable
rendered = true;
}
-
/**
* Gets the message level; can be used by rendering components. Note that what actually happens
* with the level indication is totally up to the components that render feedback messages.
@@ -270,9 +268,6 @@ public class FeedbackMessage implements IDetachable
return (getLevel() == UNDEFINED);
}
- /**
- * @see java.lang.Object#toString()
- */
@Override
public String toString()
{
@@ -281,7 +276,6 @@ public class FeedbackMessage implements IDetachable
getLevelAsString() + ']';
}
- /** {@inheritDoc} */
@Override
public void detach()
{
http://git-wip-us.apache.org/repos/asf/wicket/blob/547a7e14/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessages.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessages.java b/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessages.java
index fe2a96b..2177873 100644
--- a/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessages.java
+++ b/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessages.java
@@ -55,7 +55,7 @@ public final class FeedbackMessages implements IClusterable, Iterable<FeedbackMe
*/
public FeedbackMessages()
{
- messages = new CopyOnWriteArrayList<FeedbackMessage>();
+ messages = new CopyOnWriteArrayList<>();
}
/**
@@ -190,7 +190,6 @@ public final class FeedbackMessages implements IClusterable, Iterable<FeedbackMe
List<FeedbackMessage> toDelete = messages(filter);
-
for (FeedbackMessage message : toDelete)
{
message.detach();
http://git-wip-us.apache.org/repos/asf/wicket/blob/547a7e14/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessagesModel.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessagesModel.java b/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessagesModel.java
index 6c17478..d6d915a 100644
--- a/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessagesModel.java
+++ b/wicket-core/src/main/java/org/apache/wicket/feedback/FeedbackMessagesModel.java
@@ -92,9 +92,6 @@ public class FeedbackMessagesModel implements IModel<List<FeedbackMessage>>
return sortingComparator;
}
- /**
- * @see org.apache.wicket.model.IModel#getObject()
- */
@Override
public final List<FeedbackMessage> getObject()
{
@@ -173,22 +170,14 @@ public class FeedbackMessagesModel implements IModel<List<FeedbackMessage>>
return messages;
}
- /**
- *
- * @see org.apache.wicket.model.IModel#setObject(java.lang.Object)
- */
@Override
public void setObject(List<FeedbackMessage> object)
{
}
- /**
- *
- * @see org.apache.wicket.model.IDetachable#detach()
- */
@Override
public void detach()
{
messages = null;
}
-}
\ No newline at end of file
+}
http://git-wip-us.apache.org/repos/asf/wicket/blob/547a7e14/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ResourceLink.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ResourceLink.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ResourceLink.java
index 2e1f0c4..dcfe7a5 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ResourceLink.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ResourceLink.java
@@ -95,9 +95,6 @@ public class ResourceLink<T> extends Link<T> implements IRequestListener
resourceParameters = null;
}
- /**
- * @see org.apache.wicket.markup.html.link.Link#onClick()
- */
@Override
public void onClick()
{
@@ -109,13 +106,9 @@ public class ResourceLink<T> extends Link<T> implements IRequestListener
return false;
}
- /**
- * @see org.apache.wicket.IResourceListener#onResourceRequested()
- */
@Override
public final void onRequest()
{
-
Attributes a = new Attributes(RequestCycle.get().getRequest(), RequestCycle.get()
.getResponse(), null);
resource.respond(a);
@@ -123,9 +116,6 @@ public class ResourceLink<T> extends Link<T> implements IRequestListener
super.onRequest();
}
- /**
- * @see org.apache.wicket.markup.html.link.Link#getURL()
- */
@Override
protected final CharSequence getURL()
{