You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2011/05/30 15:34:47 UTC
[jira] [Created] (HAMA-396) Allow 'host:port' format for zookeeper
address
Allow 'host:port' format for zookeeper address
----------------------------------------------
Key: HAMA-396
URL: https://issues.apache.org/jira/browse/HAMA-396
Project: Hama
Issue Type: Improvement
Components: bsp
Affects Versions: 0.2.0
Reporter: Edward J. Yoon
Priority: Minor
Fix For: 0.3.0
Zookeeper/HBase uses 'host:port' format but Hama doesn't. Many user can be confused.
{code}
zookeeperAddr = conf.get(Constants.ZOOKEEPER_QUORUM)
+ ":"
+ conf.getInt(Constants.ZOOKEPER_CLIENT_PORT,
Constants.DEFAULT_ZOOKEPER_CLIENT_PORT);
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-396) Allow 'host:port' format for zookeeper
address
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-396:
--------------------------------
Fix Version/s: 0.2.1
Because of this problem, I made very dirty code for whirr. :/
{code}
String quorum = ZooKeeperCluster.getHosts(cluster);
quorum = quorum.split(":")[0];
{code}
Let's schedule this to 0.2.1
> Allow 'host:port' format for zookeeper address
> ----------------------------------------------
>
> Key: HAMA-396
> URL: https://issues.apache.org/jira/browse/HAMA-396
> Project: Hama
> Issue Type: Improvement
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Priority: Minor
> Fix For: 0.3.0, 0.2.1
>
>
> Zookeeper/HBase uses 'host:port' format but Hama doesn't. Many user can be confused.
> {code}
> zookeeperAddr = conf.get(Constants.ZOOKEEPER_QUORUM)
> + ":"
> + conf.getInt(Constants.ZOOKEPER_CLIENT_PORT,
> Constants.DEFAULT_ZOOKEPER_CLIENT_PORT);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-396) Allow 'host:port' format for
zookeeper address
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049086#comment-13049086 ]
Hudson commented on HAMA-396:
-----------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482535/HAMA-396_v02.patch
against trunk revision 1134490.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 6 new or modified tests.
core tests +1. The patch passed core unit tests.
Changes : http://builds.apache.org/hudson/job/Hama-Patch/342/changes/
Console output: http://builds.apache.org/hudson/job/Hama-Patch/342/console
This message is automatically generated.
> Allow 'host:port' format for zookeeper address
> ----------------------------------------------
>
> Key: HAMA-396
> URL: https://issues.apache.org/jira/browse/HAMA-396
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.3.0
>
> Attachments: HAMA-396.patch, HAMA-396_v02.patch
>
>
> Zookeeper/HBase uses 'host:port' format but Hama doesn't. Many user can be confused.
> {code}
> zookeeperAddr = conf.get(Constants.ZOOKEEPER_QUORUM)
> + ":"
> + conf.getInt(Constants.ZOOKEPER_CLIENT_PORT,
> Constants.DEFAULT_ZOOKEPER_CLIENT_PORT);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-396) Allow 'host:port' format for zookeeper
address
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-396:
--------------------------------
Fix Version/s: (was: 0.2.1)
> Allow 'host:port' format for zookeeper address
> ----------------------------------------------
>
> Key: HAMA-396
> URL: https://issues.apache.org/jira/browse/HAMA-396
> Project: Hama
> Issue Type: Improvement
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Priority: Minor
> Fix For: 0.3.0
>
>
> Zookeeper/HBase uses 'host:port' format but Hama doesn't. Many user can be confused.
> {code}
> zookeeperAddr = conf.get(Constants.ZOOKEEPER_QUORUM)
> + ":"
> + conf.getInt(Constants.ZOOKEPER_CLIENT_PORT,
> Constants.DEFAULT_ZOOKEPER_CLIENT_PORT);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-396) Allow 'host:port' format for zookeeper
address
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-396:
--------------------------------
Status: Patch Available (was: Open)
submit my patch.
> Allow 'host:port' format for zookeeper address
> ----------------------------------------------
>
> Key: HAMA-396
> URL: https://issues.apache.org/jira/browse/HAMA-396
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.3.0
>
> Attachments: HAMA-396.patch
>
>
> Zookeeper/HBase uses 'host:port' format but Hama doesn't. Many user can be confused.
> {code}
> zookeeperAddr = conf.get(Constants.ZOOKEEPER_QUORUM)
> + ":"
> + conf.getInt(Constants.ZOOKEPER_CLIENT_PORT,
> Constants.DEFAULT_ZOOKEPER_CLIENT_PORT);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-396) Allow 'host:port' format for zookeeper
address
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-396:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Fixed!
> Allow 'host:port' format for zookeeper address
> ----------------------------------------------
>
> Key: HAMA-396
> URL: https://issues.apache.org/jira/browse/HAMA-396
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.3.0
>
> Attachments: HAMA-396.patch, HAMA-396_v02.patch
>
>
> Zookeeper/HBase uses 'host:port' format but Hama doesn't. Many user can be confused.
> {code}
> zookeeperAddr = conf.get(Constants.ZOOKEEPER_QUORUM)
> + ":"
> + conf.getInt(Constants.ZOOKEPER_CLIENT_PORT,
> Constants.DEFAULT_ZOOKEPER_CLIENT_PORT);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-396) Allow 'host:port' format for
zookeeper address
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049056#comment-13049056 ]
Edward J. Yoon commented on HAMA-396:
-------------------------------------
I have to explain more clearly.
- We have to use 'quorum server list' when construct new zookeeper object.
- 'host:port' format was not a problem.
- I added getZKQuorumServersString() method.
> Allow 'host:port' format for zookeeper address
> ----------------------------------------------
>
> Key: HAMA-396
> URL: https://issues.apache.org/jira/browse/HAMA-396
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.3.0
>
> Attachments: HAMA-396.patch
>
>
> Zookeeper/HBase uses 'host:port' format but Hama doesn't. Many user can be confused.
> {code}
> zookeeperAddr = conf.get(Constants.ZOOKEEPER_QUORUM)
> + ":"
> + conf.getInt(Constants.ZOOKEPER_CLIENT_PORT,
> Constants.DEFAULT_ZOOKEPER_CLIENT_PORT);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-396) Allow 'host:port' format for zookeeper
address
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-396:
--------------------------------
Status: Patch Available (was: Open)
Rescheduling.
> Allow 'host:port' format for zookeeper address
> ----------------------------------------------
>
> Key: HAMA-396
> URL: https://issues.apache.org/jira/browse/HAMA-396
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.3.0
>
> Attachments: HAMA-396.patch, HAMA-396_v02.patch
>
>
> Zookeeper/HBase uses 'host:port' format but Hama doesn't. Many user can be confused.
> {code}
> zookeeperAddr = conf.get(Constants.ZOOKEEPER_QUORUM)
> + ":"
> + conf.getInt(Constants.ZOOKEPER_CLIENT_PORT,
> Constants.DEFAULT_ZOOKEPER_CLIENT_PORT);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-396) Allow 'host:port' format for
zookeeper address
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049032#comment-13049032 ]
Hudson commented on HAMA-396:
-----------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482521/HAMA-396.patch
against trunk revision 1134490.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
core tests +1. The patch passed core unit tests.
Changes : http://builds.apache.org/hudson/job/Hama-Patch/341/changes/
Console output: http://builds.apache.org/hudson/job/Hama-Patch/341/console
This message is automatically generated.
> Allow 'host:port' format for zookeeper address
> ----------------------------------------------
>
> Key: HAMA-396
> URL: https://issues.apache.org/jira/browse/HAMA-396
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.3.0
>
> Attachments: HAMA-396.patch
>
>
> Zookeeper/HBase uses 'host:port' format but Hama doesn't. Many user can be confused.
> {code}
> zookeeperAddr = conf.get(Constants.ZOOKEEPER_QUORUM)
> + ":"
> + conf.getInt(Constants.ZOOKEPER_CLIENT_PORT,
> Constants.DEFAULT_ZOOKEPER_CLIENT_PORT);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-396) Allow 'host:port' format for zookeeper
address
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-396:
--------------------------------
Attachment: HAMA-396.patch
Here's my patch.
> Allow 'host:port' format for zookeeper address
> ----------------------------------------------
>
> Key: HAMA-396
> URL: https://issues.apache.org/jira/browse/HAMA-396
> Project: Hama
> Issue Type: Improvement
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Priority: Minor
> Fix For: 0.3.0
>
> Attachments: HAMA-396.patch
>
>
> Zookeeper/HBase uses 'host:port' format but Hama doesn't. Many user can be confused.
> {code}
> zookeeperAddr = conf.get(Constants.ZOOKEEPER_QUORUM)
> + ":"
> + conf.getInt(Constants.ZOOKEPER_CLIENT_PORT,
> Constants.DEFAULT_ZOOKEPER_CLIENT_PORT);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-396) Allow 'host:port' format for zookeeper
address
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-396:
--------------------------------
Attachment: HAMA-396_v02.patch
Added simple unit test.
> Allow 'host:port' format for zookeeper address
> ----------------------------------------------
>
> Key: HAMA-396
> URL: https://issues.apache.org/jira/browse/HAMA-396
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.3.0
>
> Attachments: HAMA-396.patch, HAMA-396_v02.patch
>
>
> Zookeeper/HBase uses 'host:port' format but Hama doesn't. Many user can be confused.
> {code}
> zookeeperAddr = conf.get(Constants.ZOOKEEPER_QUORUM)
> + ":"
> + conf.getInt(Constants.ZOOKEPER_CLIENT_PORT,
> Constants.DEFAULT_ZOOKEPER_CLIENT_PORT);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HAMA-396) Allow 'host:port' format for zookeeper
address
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon reassigned HAMA-396:
-----------------------------------
Assignee: Edward J. Yoon
> Allow 'host:port' format for zookeeper address
> ----------------------------------------------
>
> Key: HAMA-396
> URL: https://issues.apache.org/jira/browse/HAMA-396
> Project: Hama
> Issue Type: Improvement
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Priority: Minor
> Fix For: 0.3.0
>
> Attachments: HAMA-396.patch
>
>
> Zookeeper/HBase uses 'host:port' format but Hama doesn't. Many user can be confused.
> {code}
> zookeeperAddr = conf.get(Constants.ZOOKEEPER_QUORUM)
> + ":"
> + conf.getInt(Constants.ZOOKEPER_CLIENT_PORT,
> Constants.DEFAULT_ZOOKEPER_CLIENT_PORT);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-396) Allow 'host:port' format for zookeeper
address
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-396:
--------------------------------
Status: Open (was: Patch Available)
> Allow 'host:port' format for zookeeper address
> ----------------------------------------------
>
> Key: HAMA-396
> URL: https://issues.apache.org/jira/browse/HAMA-396
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.3.0
>
> Attachments: HAMA-396.patch, HAMA-396_v02.patch
>
>
> Zookeeper/HBase uses 'host:port' format but Hama doesn't. Many user can be confused.
> {code}
> zookeeperAddr = conf.get(Constants.ZOOKEEPER_QUORUM)
> + ":"
> + conf.getInt(Constants.ZOOKEPER_CLIENT_PORT,
> Constants.DEFAULT_ZOOKEPER_CLIENT_PORT);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-396) Allow 'host:port' format for zookeeper
address
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-396:
--------------------------------
Priority: Major (was: Minor)
Issue Type: Bug (was: Improvement)
It was a bug.
> Allow 'host:port' format for zookeeper address
> ----------------------------------------------
>
> Key: HAMA-396
> URL: https://issues.apache.org/jira/browse/HAMA-396
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.3.0
>
> Attachments: HAMA-396.patch
>
>
> Zookeeper/HBase uses 'host:port' format but Hama doesn't. Many user can be confused.
> {code}
> zookeeperAddr = conf.get(Constants.ZOOKEEPER_QUORUM)
> + ":"
> + conf.getInt(Constants.ZOOKEPER_CLIENT_PORT,
> Constants.DEFAULT_ZOOKEPER_CLIENT_PORT);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira