You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2018/04/04 19:54:43 UTC
[kudu-CR] KUDU-16: remove Java warnings wrt scanner limits
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9926
Change subject: KUDU-16: remove Java warnings wrt scanner limits
......................................................................
KUDU-16: remove Java warnings wrt scanner limits
With the introduction of server-side support, the Java client is pretty
much already set up to work with limits. This patch removes some of the
warnings that were in place for until the feature landed and adds a test
to ensure it's working.
Change-Id: I83635fbbc7714318f8b95d91b7f178e9ca7ebff7
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
3 files changed, 26 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/9926/1
--
To view, visit http://gerrit.cloudera.org:8080/9926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83635fbbc7714318f8b95d91b7f178e9ca7ebff7
Gerrit-Change-Number: 9926
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] KUDU-16: implement Java client limits
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9926
to look at the new patch set (#2).
Change subject: KUDU-16: implement Java client limits
......................................................................
KUDU-16: implement Java client limits
This patch implements the scanner limits for the Java client. Each
AsyncKuduScanner will maintain a count of the number of rows already
returned (per table scan), and based on this value, will update the
per-tablet scan request.
Change-Id: I83635fbbc7714318f8b95d91b7f178e9ca7ebff7
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
3 files changed, 55 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/9926/2
--
To view, visit http://gerrit.cloudera.org:8080/9926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I83635fbbc7714318f8b95d91b7f178e9ca7ebff7
Gerrit-Change-Number: 9926
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-16: implement Java client limits
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9926 )
Change subject: KUDU-16: implement Java client limits
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83635fbbc7714318f8b95d91b7f178e9ca7ebff7
Gerrit-Change-Number: 9926
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 05 Apr 2018 17:07:58 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-16: implement Java client limits
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9926 )
Change subject: KUDU-16: implement Java client limits
......................................................................
KUDU-16: implement Java client limits
This patch implements the scanner limits for the Java client. Each
AsyncKuduScanner will maintain a count of the number of rows already
returned (per table scan), and based on this value, will update the
per-tablet scan request.
Change-Id: I83635fbbc7714318f8b95d91b7f178e9ca7ebff7
Reviewed-on: http://gerrit.cloudera.org:8080/9926
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
3 files changed, 57 insertions(+), 7 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I83635fbbc7714318f8b95d91b7f178e9ca7ebff7
Gerrit-Change-Number: 9926
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-16: remove Java warnings wrt scanner limits
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9926 )
Change subject: KUDU-16: remove Java warnings wrt scanner limits
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9926/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/9926/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@504
PS1, Line 504: int limits[] = { num_rows - 1, num_rows, num_rows + 1 };
Can you add 0 here?
What happens if there is a negative value?
--
To view, visit http://gerrit.cloudera.org:8080/9926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83635fbbc7714318f8b95d91b7f178e9ca7ebff7
Gerrit-Change-Number: 9926
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 04 Apr 2018 19:57:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-16: implement Java client limits
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9926 )
Change subject: KUDU-16: implement Java client limits
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9926/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java:
http://gerrit.cloudera.org:8080/#/c/9926/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@574
PS2, Line 574: // Stop scanning if we have scanned until or past the end partition key.
Nit: Adjust this comment
--
To view, visit http://gerrit.cloudera.org:8080/9926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83635fbbc7714318f8b95d91b7f178e9ca7ebff7
Gerrit-Change-Number: 9926
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 05 Apr 2018 14:00:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-16: implement Java client limits
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9926 )
Change subject: KUDU-16: implement Java client limits
......................................................................
Patch Set 2:
(1 comment)
Turns out extra bookkeeping was necessary.
http://gerrit.cloudera.org:8080/#/c/9926/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/9926/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@504
PS1, Line 504:
> Can you add 0 here?
Done
--
To view, visit http://gerrit.cloudera.org:8080/9926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83635fbbc7714318f8b95d91b7f178e9ca7ebff7
Gerrit-Change-Number: 9926
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 05 Apr 2018 01:32:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-16: implement Java client limits
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9926
to look at the new patch set (#3).
Change subject: KUDU-16: implement Java client limits
......................................................................
KUDU-16: implement Java client limits
This patch implements the scanner limits for the Java client. Each
AsyncKuduScanner will maintain a count of the number of rows already
returned (per table scan), and based on this value, will update the
per-tablet scan request.
Change-Id: I83635fbbc7714318f8b95d91b7f178e9ca7ebff7
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
3 files changed, 57 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/9926/3
--
To view, visit http://gerrit.cloudera.org:8080/9926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I83635fbbc7714318f8b95d91b7f178e9ca7ebff7
Gerrit-Change-Number: 9926
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins