[jira] [Work logged] (BEAM-7732) Allow access to SpannerOptions in Beam

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-7732?focusedWorklogId=320054&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320054 ]

ASF GitHub Bot logged work on BEAM-7732:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Sep/19 20:20
            Start Date: 28/Sep/19 20:20
    Worklog Time Spent: 10m 
      Work Description: stale[bot] commented on issue #9048: [BEAM-7732] Enable setting custom SpannerOptions.
URL: https://github.com/apache/beam/pull/9048#issuecomment-536222454
 
 
   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 320054)
    Time Spent: 1h 10m  (was: 1h)

> Allow access to SpannerOptions in Beam
> --------------------------------------
>
>                 Key: BEAM-7732
>                 URL: https://issues.apache.org/jira/browse/BEAM-7732
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-gcp
>    Affects Versions: 2.12.0, 2.13.0
>            Reporter: Niel Markwick
>            Priority: Minor
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Beam hides the [SpannerOptions|https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java] object behind a [SpannerConfig|https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerConfig.java] object because the SpannerOptions object is not serializable. 
> This means that the only options that can be set are those that can be specified in SpannerConfig - limited to host, project, instance, database.
> Suggestion: add the possibility to set a SpannerOptionsFactory in SpannerConfig:
> {code:java}
> public interface SpannerOptionsFactory extends Serializable {
>    public SpannerOptions create();
> }
> {code}
> This would allow the user use this factory class to specify custom SpannerOptions before they are passed onto the connectToSpanner() method; 
> connectToSpanner() would then become: 
> {code:java}
> public SpannerAccessor connectToSpanner() {
>   
>   SpannerOptions.Builder builder = spannerOptionsFactory.create().toBuilder();
>   // rest of connectToSpanner follows, setting project, host, etc.
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)