You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "Nicklee007 (via GitHub)" <gi...@apache.org> on 2023/03/15 06:53:22 UTC
[GitHub] [bookkeeper] Nicklee007 opened a new pull request, #3867: Modify the response code from 404 to 405 when method not allowed.
Nicklee007 opened a new pull request, #3867:
URL: https://github.com/apache/bookkeeper/pull/3867
### Motivation
Response code 405 `METHOD_NOT_ALLOWED` is better than 404 `NOT_FOUND` when client request used not allowed method from REST API.
### Changes
1. Modify response code 404 to 405 when client request used not allowed method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] codecov-commenter commented on pull request #3867: Modify the response code from 404 to 405 when method not allowed.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3867:
URL: https://github.com/apache/bookkeeper/pull/3867#issuecomment-1469472186
## [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3867?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3867](https://codecov.io/gh/apache/bookkeeper/pull/3867?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f40e49e) into [master](https://codecov.io/gh/apache/bookkeeper/commit/0fa39b6236fb20f5ff527d62300e0988ca9c5836?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0fa39b6) will **decrease** coverage by `47.29%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #3867 +/- ##
=============================================
- Coverage 68.30% 21.01% -47.29%
+ Complexity 6787 2026 -4761
=============================================
Files 474 474
Lines 41112 41112
Branches 5256 5256
=============================================
- Hits 28080 8639 -19441
- Misses 10782 31206 +20424
+ Partials 2250 1267 -983
```
| Flag | Coverage Δ | |
|---|---|---|
| bookie | `?` | |
| client | `?` | |
| remaining | `?` | |
| replication | `?` | |
| tls | `21.01% <0.00%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/bookkeeper/pull/3867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/http/service/AutoRecoveryStatusService.java](https://codecov.io/gh/apache/bookkeeper/pull/3867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2h0dHAvc2VydmljZS9BdXRvUmVjb3ZlcnlTdGF0dXNTZXJ2aWNlLmphdmE=) | `0.00% <ø> (-73.34%)` | :arrow_down: |
| [...kkeeper/server/http/service/BookieInfoService.java](https://codecov.io/gh/apache/bookkeeper/pull/3867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2h0dHAvc2VydmljZS9Cb29raWVJbmZvU2VydmljZS5qYXZh) | `0.00% <0.00%> (-87.50%)` | :arrow_down: |
| [...eper/server/http/service/BookieIsReadyService.java](https://codecov.io/gh/apache/bookkeeper/pull/3867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2h0dHAvc2VydmljZS9Cb29raWVJc1JlYWR5U2VydmljZS5qYXZh) | `0.00% <0.00%> (-93.34%)` | :arrow_down: |
| [...eeper/server/http/service/BookieSanityService.java](https://codecov.io/gh/apache/bookkeeper/pull/3867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2h0dHAvc2VydmljZS9Cb29raWVTYW5pdHlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-59.38%)` | :arrow_down: |
| [...erver/http/service/BookieStateReadOnlyService.java](https://codecov.io/gh/apache/bookkeeper/pull/3867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2h0dHAvc2VydmljZS9Cb29raWVTdGF0ZVJlYWRPbmx5U2VydmljZS5qYXZh) | `0.00% <0.00%> (-69.57%)` | :arrow_down: |
| [...keeper/server/http/service/BookieStateService.java](https://codecov.io/gh/apache/bookkeeper/pull/3867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2h0dHAvc2VydmljZS9Cb29raWVTdGF0ZVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-79.17%)` | :arrow_down: |
| [...keeper/server/http/service/ClusterInfoService.java](https://codecov.io/gh/apache/bookkeeper/pull/3867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2h0dHAvc2VydmljZS9DbHVzdGVySW5mb1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-88.00%)` | :arrow_down: |
| [...eper/server/http/service/ConfigurationService.java](https://codecov.io/gh/apache/bookkeeper/pull/3867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2h0dHAvc2VydmljZS9Db25maWd1cmF0aW9uU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...eeper/server/http/service/DecommissionService.java](https://codecov.io/gh/apache/bookkeeper/pull/3867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2h0dHAvc2VydmljZS9EZWNvbW1pc3Npb25TZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-69.24%)` | :arrow_down: |
| [...eeper/server/http/service/DeleteLedgerService.java](https://codecov.io/gh/apache/bookkeeper/pull/3867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2h0dHAvc2VydmljZS9EZWxldGVMZWRnZXJTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-88.89%)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/apache/bookkeeper/pull/3867?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [353 files with indirect coverage changes](https://codecov.io/gh/apache/bookkeeper/pull/3867/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Nicklee007 closed pull request #3867: Modify the response code from 404 to 405 when method not allowed.
Posted by "Nicklee007 (via GitHub)" <gi...@apache.org>.
Nicklee007 closed pull request #3867: Modify the response code from 404 to 405 when method not allowed.
URL: https://github.com/apache/bookkeeper/pull/3867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org